Bug 145257 - Layout Test http/tests/media/media-document-referer.html is flaky
Summary: Layout Test http/tests/media/media-document-referer.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-21 04:10 PDT by Marcos Chavarría Teijeiro (irc: chavaone)
Modified: 2015-09-16 08:49 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (1.97 KB, patch)
2015-09-14 22:33 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-05-21 04:10:45 PDT 
The http/tests/media/media-document-referer.html layout test is flaky on GTK+. It fails sometimes.

The diff is the following:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/media-document-referer-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/media-document-referer-actual.txt
@@ -1,5 +1,5 @@
 Tests that a media document has correct referer header.
 
-video loaded, referer was correct! OK
+TIMEOUT: video failed to load without an error. FAIL
 END OF TEST
Comment 1 Alexey Proskuryakov 2015-09-14 22:30:26 PDT 
This test started to be (very) flaky on Mac, too. It doesn't seem like there was any specific change, my guess is that it's timing. 

The test expects that the video will load within a second - that doesn't seem like a reasonable expectation for a regression test, which operate under huge CPU load.
Comment 2 Alexey Proskuryakov 2015-09-14 22:33:33 PDT 
Created attachment 261176 [details]
proposed fix
Comment 3 WebKit Commit Bot 2015-09-14 23:47:02 PDT 
Comment on attachment 261176 [details]
proposed fix

Clearing flags on attachment: 261176

Committed r189778: <http://trac.webkit.org/changeset/189778>
Comment 4 WebKit Commit Bot 2015-09-14 23:47:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2015-09-16 08:49:14 PDT 
This fixed it.