We should consider the AutoFill button and <input type="search"> cancel button to be hit testable.
<rdar://problem/21051411>
Created attachment 253495 [details] Work-in-progress patch Need to add change log entry. I am open to suggestions on the approach.
Comment on attachment 253495 [details] Work-in-progress patch I think you should follow the model of image maps, where you identify its a text field and then have a method that handles sub element hit testing if necessary
Created attachment 253616 [details] Patch and layout test
Comment on attachment 253616 [details] Patch and layout test View in context: https://bugs.webkit.org/attachment.cgi?id=253616&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2239 > + return accessibilityTextFieldDecoration(downcast<HTMLInputElement>(*node), *hitTestResult.innerNode()); will this still return the text field if the textFieldDecoration returns null? i would also name accessibilityTextFieldDecoration -> accessibilityTextFieldDecorationHitTest to match the other methods you could also make that an instance method so that you can access the axObjectCache() directly instead of getting it through inputElement.document(). That probably doesn't impact anything though > LayoutTests/platform/wk2/TestExpectations:53 > +webkit.org/b/71298 accessibility/input-search-cancel-button.html [ Failure ] do we know why this fails on wk2? that seems like something we shouldn't ignore. thanks
Comment on attachment 253616 [details] Patch and layout test Attachment 253616 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6679441056989184 New failing tests: platform/mac/accessibility/html-slider-indicator.html
Created attachment 253619 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 253616 [details] Patch and layout test Clearing review flag. Will update patch and address remarks shortly.
(In reply to comment #5) > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2239 > > + return accessibilityTextFieldDecoration(downcast<HTMLInputElement>(*node), *hitTestResult.innerNode()); > > will this still return the text field if the textFieldDecoration returns > null? > No, it will not return the text field. Will fix. > i would also name > > accessibilityTextFieldDecoration -> accessibilityTextFieldDecorationHitTest > to match the other methods > Will rename. > you could also make that an instance method so that you can access the > axObjectCache() directly instead of getting it through > inputElement.document(). > That probably doesn't impact anything though > Will make it an instance method and access axObjectCache() directly. > > LayoutTests/platform/wk2/TestExpectations:53 > > +webkit.org/b/71298 accessibility/input-search-cancel-button.html [ Failure ] > > do we know why this fails on wk2? that seems like something we shouldn't > ignore. > It fails because of bug #71298. See bug 71298, comment 53 for more details.
Created attachment 255271 [details] Patch and layout tests
Comment on attachment 255271 [details] Patch and layout tests Clearing flags on attachment: 255271 Committed r185828: <http://trac.webkit.org/changeset/185828>
All reviewed patches have been landed. Closing bug.
This caused 3 tests to fail on Windows: accessibility/hit-test-input-auto-fill-button.html accessibility/hit-test-input-search-cancel-button.html accessibility/input-search-cancel-button.html
(In reply to comment #13) > This caused 3 tests to fail on Windows: > accessibility/hit-test-input-auto-fill-button.html > accessibility/hit-test-input-search-cancel-button.html > accessibility/input-search-cancel-button.html Filed bug #146243 to look into these failures. For now, I'll skip the tests.
(In reply to comment #14) > (In reply to comment #13) > > This caused 3 tests to fail on Windows: > > accessibility/hit-test-input-auto-fill-button.html > > accessibility/hit-test-input-search-cancel-button.html > > accessibility/input-search-cancel-button.html > > Filed bug #146243 to look into these failures. For now, I'll skip the tests. Actually, I chose to mark the tests as failing and committed this in <http://trac.webkit.org/changeset/185881>.
Rolled out <http://trac.webkit.org/changeset/185881> and <http://trac.webkit.org/changeset/185828> in <http://trac.webkit.org/changeset/186011> because it caused a regression.