Bug 145239 - Fix macros for wireless playback
Summary: Fix macros for wireless playback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on: 145314 145315 145316 145477
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-20 18:34 PDT by Jon Lee
Modified: 2015-05-29 15:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.41 KB, patch)
2015-05-26 17:36 PDT, Jon Lee
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2015-05-20 18:34:38 PDT
Update support for wireless playback
rdar://problem/21049541
Comment 1 Jon Lee 2015-05-26 17:36:42 PDT
Created attachment 253764 [details]
Patch
Comment 2 Anders Carlsson 2015-05-26 17:46:38 PDT
Comment on attachment 253764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253764&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:350
> +    return _allowsAirPlayForMediaPlayback;
> +}
> +
> +- (void)setMediaPlaybackAllowsAirPlay:(BOOL)allowed
> +{
> +    _allowsAirPlayForMediaPlayback = allowed;
> +}
> +
> +- (BOOL)mediaPlaybackRequiresUserAction
> +{
> +    return _requiresUserActionForMediaPlayback;
> +}
> +
> +- (void)setMediaPlaybackRequiresUserAction:(BOOL)required
> +{
> +    _requiresUserActionForMediaPlayback = required;

I think this should just call into the API methods instead of dealing with ivars directly.
Comment 3 Jon Lee 2015-05-26 18:21:35 PDT
Comment on attachment 253764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253764&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:350
>> +    _requiresUserActionForMediaPlayback = required;
> 
> I think this should just call into the API methods instead of dealing with ivars directly.

Ok, I will make that adjustment when I check in the patch.
Comment 4 Jon Lee 2015-05-28 00:27:30 PDT
Committed r184946: <http://trac.webkit.org/changeset/184946>