Bug 145239 – Fix macros for wireless playback

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jon Lee]

Update support for wireless playback
rdar://problem/21049541

[Jon Lee]

Created attachment 253764 [details]
Patch

[Anders Carlsson]

Comment on attachment 253764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253764&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:350
> +    return _allowsAirPlayForMediaPlayback;
> +}
> +
> +- (void)setMediaPlaybackAllowsAirPlay:(BOOL)allowed
> +{
> +    _allowsAirPlayForMediaPlayback = allowed;
> +}
> +
> +- (BOOL)mediaPlaybackRequiresUserAction
> +{
> +    return _requiresUserActionForMediaPlayback;
> +}
> +
> +- (void)setMediaPlaybackRequiresUserAction:(BOOL)required
> +{
> +    _requiresUserActionForMediaPlayback = required;

I think this should just call into the API methods instead of dealing with ivars directly.

[Jon Lee]

Comment on attachment 253764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253764&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:350
>> +    _requiresUserActionForMediaPlayback = required;
> 
> I think this should just call into the API methods instead of dealing with ivars directly.

Ok, I will make that adjustment when I check in the patch.

[Jon Lee]

Committed r184946: <http://trac.webkit.org/changeset/184946>