Bug 145235 - Web Inspector: Use native Arguments detection instead of using toString
Summary: Web Inspector: Use native Arguments detection instead of using toString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-05-20 18:00 PDT by Joseph Pecoraro
Modified: 2015-05-20 22:12 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.73 KB, patch)
2015-05-20 18:14 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-20 18:00:37 PDT
* SUMMARY
Use native Arguments detection instead of using toString.

Technically Object.prototype.toString could be overridden anyways. But I still think it is weird to do a toString check here.
Comment 1 Joseph Pecoraro 2015-05-20 18:14:12 PDT
Created attachment 253485 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-05-20 22:12:14 PDT
Comment on attachment 253485 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253485

Committed r184697: <http://trac.webkit.org/changeset/184697>
Comment 3 WebKit Commit Bot 2015-05-20 22:12:18 PDT
All reviewed patches have been landed.  Closing bug.