RESOLVED FIXED145233
Add option to run_jsc_stress_tests to disable JIT testing 
https://bugs.webkit.org/show_bug.cgi?id=145233
Summary Add option to run_jsc_stress_tests to disable JIT testing
Michael Saboff
Reported 2015-05-20 17:45:21 PDT
Currently when testing a build that is compiled without the JIT using run_jsc_stress_tests, it creates test variants for the baseline, DFG and FTL for platforms with the FTL. This is unnecessary and give false failures. We should add an option to test interpreter only configurations.
Attachments
Patch (5.91 KB, patch)
2015-05-20 17:47 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated patch that always runs runAlwaysTriggerCopyPhase (5.88 KB, patch)
2015-05-20 18:03 PDT, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2015-05-20 17:47:32 PDT
Created attachment 253479 [details] Patch
Mark Lam
Comment 2 2015-05-20 17:56:27 PDT
Comment on attachment 253479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253479&action=review > Tools/Scripts/run-jsc-stress-tests:787 > + runAlwaysTriggerCopyPhase Shouldn’t runAlwaysTriggerCopyPhase be run in the no JIT configuration? > Tools/Scripts/run-jsc-stress-tests:987 > + if $jitTests > + runMozillaTestLLInt(mode, *extraFiles) Shouldn’t we be running the “runMozillaTestLLInt” version?
Michael Saboff
Comment 3 2015-05-20 17:59:29 PDT
(In reply to comment #2) > Comment on attachment 253479 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253479&action=review > > > Tools/Scripts/run-jsc-stress-tests:787 > > + runAlwaysTriggerCopyPhase > > Shouldn’t runAlwaysTriggerCopyPhase be run in the no JIT configuration? The "no JIT" will effectively run the same test that ran in the "default" case. > > Tools/Scripts/run-jsc-stress-tests:987 > > + if $jitTests > > + runMozillaTestLLInt(mode, *extraFiles) > > Shouldn’t we be running the “runMozillaTestLLInt” version? Ditto.
Michael Saboff
Comment 4 2015-05-20 18:03:56 PDT
Created attachment 253481 [details] Updated patch that always runs runAlwaysTriggerCopyPhase
Mark Lam
Comment 5 2015-05-20 18:08:03 PDT
Comment on attachment 253481 [details] Updated patch that always runs runAlwaysTriggerCopyPhase r=me
Michael Saboff
Comment 6 2015-05-20 18:14:22 PDT
Committed r184683: <http://trac.webkit.org/changeset/184683>
Note You need to log in before you can comment on or make changes to this bug.