Bug 145233 - Add option to run_jsc_stress_tests to disable JIT testing
Summary: Add option to run_jsc_stress_tests to disable JIT testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-20 17:45 PDT by Michael Saboff
Modified: 2015-05-20 18:14 PDT (History)
0 users

See Also:

Attachments
Patch (5.91 KB, patch)
2015-05-20 17:47 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Updated patch that always runs runAlwaysTriggerCopyPhase (5.88 KB, patch)
2015-05-20 18:03 PDT, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-05-20 17:45:21 PDT 
Currently when testing a build that is compiled without the JIT using run_jsc_stress_tests, it creates test variants for the baseline, DFG and FTL for platforms with the FTL.  This is unnecessary and give false failures.

We should add an option to test interpreter only configurations.
Comment 1 Michael Saboff 2015-05-20 17:47:32 PDT 
Created attachment 253479 [details]
Patch
Comment 2 Mark Lam 2015-05-20 17:56:27 PDT 
Comment on attachment 253479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253479&action=review

> Tools/Scripts/run-jsc-stress-tests:787
> +        runAlwaysTriggerCopyPhase

Shouldn’t runAlwaysTriggerCopyPhase be run in the no JIT configuration?

> Tools/Scripts/run-jsc-stress-tests:987
> +    if $jitTests
> +        runMozillaTestLLInt(mode, *extraFiles)

Shouldn’t we be running the “runMozillaTestLLInt” version?
Comment 3 Michael Saboff 2015-05-20 17:59:29 PDT 
(In reply to comment #2)
> Comment on attachment 253479 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253479&action=review
> 
> > Tools/Scripts/run-jsc-stress-tests:787
> > +        runAlwaysTriggerCopyPhase
> 
> Shouldn’t runAlwaysTriggerCopyPhase be run in the no JIT configuration?

The "no JIT" will effectively run the same test that ran in the "default" case.

> > Tools/Scripts/run-jsc-stress-tests:987
> > +    if $jitTests
> > +        runMozillaTestLLInt(mode, *extraFiles)
> 
> Shouldn’t we be running the “runMozillaTestLLInt” version?

Ditto.
Comment 4 Michael Saboff 2015-05-20 18:03:56 PDT 
Created attachment 253481 [details]
Updated patch that always runs runAlwaysTriggerCopyPhase
Comment 5 Mark Lam 2015-05-20 18:08:03 PDT 
Comment on attachment 253481 [details]
Updated patch that always runs runAlwaysTriggerCopyPhase

r=me
Comment 6 Michael Saboff 2015-05-20 18:14:22 PDT 
Committed r184683: <http://trac.webkit.org/changeset/184683>