Allow overriding the waitForDidUpdateViewState timeout
Created attachment 253474 [details] Patch
Comment on attachment 253474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253474&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:407 > + static std::chrono::milliseconds viewStateUpdateTimeout; > + if (viewStateUpdateTimeout == std::chrono::milliseconds::zero()) { > + if (id value = [[NSUserDefaults standardUserDefaults] objectForKey:@"WebKit2OverrideViewStateUpdateTimeoutMS"]) > + viewStateUpdateTimeout = std::chrono::milliseconds([value integerValue]); > + else { > #if PLATFORM(IOS) > - auto viewStateUpdateTimeout = std::chrono::milliseconds(500); > + viewStateUpdateTimeout = std::chrono::milliseconds(500); > #else > - auto viewStateUpdateTimeout = std::chrono::milliseconds(250); > + viewStateUpdateTimeout = std::chrono::milliseconds(250); > #endif > + } > + } We should not use zero as a magic value to mean uninitialized. We should use use a lambda and initialization syntax: static std::chrono::milliseconds viewStateUpdateTimeout = [] { ... fancy code in here ... }();