Bug 145227 - REGRESSION (r172591): Can no longer style <optgroup> with colors (LayoutTests/fast/forms/select/optgroup-rendering.html)
Summary: REGRESSION (r172591): Can no longer style <optgroup> with colors (LayoutTests...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-20 16:01 PDT by Antti Koivisto
Modified: 2022-10-05 15:47 PDT (History)
2 users (show)

See Also:


Attachments
patch (9.77 KB, patch)
2015-05-20 16:07 PDT, Antti Koivisto
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-05-20 16:01:04 PDT
14/05/15 17:38 Simon Fraser:
LayoutTests/fast/forms/select/optgroup-rendering.html started to render differently at some point. It no longer shows colors in the list now.
Comment 1 Antti Koivisto 2015-05-20 16:01:28 PDT
rdar://problem/20967472
Comment 2 Antti Koivisto 2015-05-20 16:07:45 PDT
Created attachment 253471 [details]
patch
Comment 3 Darin Adler 2015-05-20 16:11:08 PDT
Comment on attachment 253471 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253471&action=review

> Source/WebCore/ChangeLog:10
> +        Use computedStyle() consistently for option and optgroup items.

Is this bad for performance?
Comment 4 Antti Koivisto 2015-05-20 16:12:48 PDT
> > Source/WebCore/ChangeLog:10
> > +        Use computedStyle() consistently for option and optgroup items.
> 
> Is this bad for performance?

No. It caches the style.
Comment 5 Ahmad Saleem 2022-10-05 15:47:30 PDT
This seems to landed in this commit:

https://github.com/WebKit/WebKit/commit/40c3076b29d48da38bec16daba7ada102275e476

and not backed out while searching via bug ID on Webkit GitHub.

Marking this as "RESOLVED FIXED". Thanks!