Bug 145205 - Add some assertions about the CFG in the loop pre-header creation phase
Summary: Add some assertions about the CFG in the loop pre-header creation phase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 145204
  Show dependency tree / graph
 
Reported: 2015-05-19 22:51 PDT by Filip Pizlo
Modified: 2015-05-20 11:41 PDT (History)
12 users (show)

See Also:

Attachments
the patch (3.98 KB, patch)
2015-05-19 22:55 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-05-19 22:51:24 PDT 
If any of these properties turned out to be false, it would just lead to a bizarre failure elsewhere (like the LICM phase), so we might as well assert these things here.
Comment 1 Filip Pizlo 2015-05-19 22:55:55 PDT 
Created attachment 253429 [details]
the patch
Comment 2 Geoffrey Garen 2015-05-20 11:10:30 PDT 
Comment on attachment 253429 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253429&action=review

r=me

> Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:133
> +            // We should validate the pre-header. If we places forExit origins on nodes only if

places => placed

> Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:135
> +            // has a forExit. We should disable hoisting to pre-headers that don't validate.

has => had
Comment 3 Filip Pizlo 2015-05-20 11:41:07 PDT 
Landed in http://trac.webkit.org/changeset/184646