Bug 145195 - Web Inspector: array previews should have a much smaller cap on values
Summary: Web Inspector: array previews should have a much smaller cap on values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-19 17:47 PDT by Timothy Hatcher
Modified: 2015-05-20 22:13 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (11.08 KB, patch)
2015-05-20 18:43 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-05-19 17:47:16 PDT 
Right now it looks like array previews will contain up to 100 items. That seems excessive, at least in the case when the array is not a top level object. For property previews, the row does not wrap, so it is often clipped at 5 or 10 items anyway. It is wasteful to include any more than that.
Comment 1 Radar WebKit Bug Importer 2015-05-19 17:47:36 PDT 
<rdar://problem/21030688>
Comment 2 Joseph Pecoraro 2015-05-20 18:39:33 PDT 
Lets do 10. For small arrays with primitives, it is not that wasteful. But I totally agree for larger arrays.
Comment 3 Joseph Pecoraro 2015-05-20 18:43:35 PDT 
Created attachment 253490 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2015-05-20 22:13:13 PDT 
Comment on attachment 253490 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253490

Committed r184699: <http://trac.webkit.org/changeset/184699>
Comment 5 WebKit Commit Bot 2015-05-20 22:13:16 PDT 
All reviewed patches have been landed.  Closing bug.