Bug 145193 - Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
Summary: Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-19 16:23 PDT by Jer Noble
Modified: 2015-05-20 16:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (65.70 KB, patch)
2015-05-19 16:33 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (65.55 KB, patch)
2015-05-20 12:23 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-05-19 16:23:17 PDT 
Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
Comment 1 Jer Noble 2015-05-19 16:33:09 PDT 
Created attachment 253410 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-19 16:36:03 PDT 
Attachment 253410 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElementEnums.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/html/HTMLMediaElementEnums.h:48:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2015-05-20 09:43:41 PDT 
Comment on attachment 253410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253410&action=review

> Source/WebCore/html/HTMLMediaElementEnums.h:45
> +    enum DelayedActionType {
> +        LoadMediaResource = 1 << 0,
> +        ConfigureTextTracks = 1 << 1,
> +        TextTrackChangesNotification = 1 << 2,
> +        ConfigureTextTrackDisplay = 1 << 3,
> +        CheckPlaybackTargetCompatablity = 1 << 4,
> +
> +        EveryDelayedAction = LoadMediaResource | ConfigureTextTracks | TextTrackChangesNotification | ConfigureTextTrackDisplay | CheckPlaybackTargetCompatablity,
> +    };

Does this need to be visible outside of HTMLMediaElement?
Comment 4 Jer Noble 2015-05-20 09:47:00 PDT 
(In reply to comment #3)
> Comment on attachment 253410 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253410&action=review
> 
> > Source/WebCore/html/HTMLMediaElementEnums.h:45
> > +    enum DelayedActionType {
> > +        LoadMediaResource = 1 << 0,
> > +        ConfigureTextTracks = 1 << 1,
> > +        TextTrackChangesNotification = 1 << 2,
> > +        ConfigureTextTrackDisplay = 1 << 3,
> > +        CheckPlaybackTargetCompatablity = 1 << 4,
> > +
> > +        EveryDelayedAction = LoadMediaResource | ConfigureTextTracks | TextTrackChangesNotification | ConfigureTextTrackDisplay | CheckPlaybackTargetCompatablity,
> > +    };
> 
> Does this need to be visible outside of HTMLMediaElement?

It does to HTMLAudioElement, but it should go inside protected:, along with all the methods which take or return it.
Comment 5 Jer Noble 2015-05-20 12:23:15 PDT 
Created attachment 253456 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-05-20 12:40:09 PDT 
Attachment 253456 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElementEnums.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/html/HTMLMediaElementEnums.h:48:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jer Noble 2015-05-20 16:12:21 PDT 
Committed r184670: <http://trac.webkit.org/changeset/184670>