WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145191
Update Autofill button icon
https://bugs.webkit.org/show_bug.cgi?id=145191
Summary
Update Autofill button icon
Daniel Bates
Reported
2015-05-19 16:14:43 PDT
Update icon of Autofill button.
Attachments
Patch
(9.91 KB, patch)
2015-05-19 16:27 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-mavericks
(541.19 KB, application/zip)
2015-05-19 17:00 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2
(568.51 KB, application/zip)
2015-05-19 17:22 PDT
,
Build Bot
no flags
Details
Patch
(12.66 KB, patch)
2015-05-20 10:39 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Patch
(12.69 KB, patch)
2015-05-20 21:59 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2015-05-19 16:14:57 PDT
<
rdar://problem/20178942
>
Daniel Bates
Comment 2
2015-05-19 16:27:19 PDT
Created
attachment 253409
[details]
Patch
Build Bot
Comment 3
2015-05-19 17:00:30 PDT
Comment on
attachment 253409
[details]
Patch
Attachment 253409
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5391357950558208
New failing tests: fast/forms/input-auto-fill-button.html
Build Bot
Comment 4
2015-05-19 17:00:35 PDT
Created
attachment 253411
[details]
Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 5
2015-05-19 17:22:16 PDT
Comment on
attachment 253409
[details]
Patch
Attachment 253409
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5282933648654336
New failing tests: fast/forms/input-auto-fill-button.html
Build Bot
Comment 6
2015-05-19 17:22:19 PDT
Created
attachment 253412
[details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Daniel Bates
Comment 7
2015-05-20 10:39:54 PDT
Created
attachment 253446
[details]
Patch Updated patch that defaults the icon to black and tints it blue on mouse press. Added expected result for OS X Mavericks. Once I land this patch I will fetch the results from the Windows bot and update the expected results for Windows in the respository in a follow up commit.
Daniel Bates
Comment 8
2015-05-20 21:59:37 PDT
Created
attachment 253502
[details]
Patch
Daniel Bates
Comment 9
2015-05-21 18:16:02 PDT
Comment on
attachment 253502
[details]
Patch Clearing flags on attachment: 253502 Committed
r184745
: <
http://trac.webkit.org/changeset/184745
>
Daniel Bates
Comment 10
2015-05-21 18:16:08 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 11
2015-05-26 13:41:25 PDT
Committed updated expected results for Windows in <
http://trac.webkit.org/changeset/184870
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug