Bug 145186 - Crash under WebCore::invalidateStyleRecursively
Summary: Crash under WebCore::invalidateStyleRecursively
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-19 14:39 PDT by Antti Koivisto
Modified: 2015-05-19 22:29 PDT (History)
1 user (show)

See Also:

Attachments
patch (4.31 KB, patch)
2015-05-19 14:59 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-05-19 14:39:20 PDT 
There are reports about crashes where we run out of stack under invalidateStyleRecursively.
Comment 1 Antti Koivisto 2015-05-19 14:59:10 PDT 
Created attachment 253406 [details]
patch
Comment 2 Antti Koivisto 2015-05-19 15:16:43 PDT 
rdar://problem/19736838
Comment 3 Andreas Kling 2015-05-19 21:12:32 PDT 
Comment on attachment 253406 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253406&action=review

r=me

> Source/WebCore/css/StyleInvalidationAnalysis.cpp:120
> +    Vector<Element*> parentStack;

I'd slap some inline capacity on this Vector.
Comment 4 Antti Koivisto 2015-05-19 22:29:07 PDT 
https://trac.webkit.org/r184615