Bug 145165 – nullptr cleanup in WebCore/xml.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Hunseop Jeong]

Replaced 0 with nullptr in WebCore/xml.

[Hunseop Jeong]

Created attachment 253375 [details]
Patch

[WebKit Commit Bot]

Attachment 253375 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter name "structuredErrorFunc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hunseop Jeong]

Created attachment 253377 [details]
Patch

[Hunseop Jeong]

(In reply to comment #2)
> Attachment 253375 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter
> name "structuredErrorFunc" adds no information, so it should be removed. 
> [readability/parameter_name] [5]
> Total errors found: 1 in 12 files
> 
Is "structuredErrorFunc" need to initialize the variable?
I removed the changes in Source/WebCore/xml/parser/XMLDocumentParserScope.h
because the style-checker inform the error.
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

[Csaba Osztrogonác]

(In reply to comment #2)
> Attachment 253375 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter
> name "structuredErrorFunc" adds no information, so it should be removed. 
> [readability/parameter_name] [5]
> Total errors found: 1 in 12 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I think it is a false positive warning, you need the 
variable name to be able to add a default parameter.

[Csaba Osztrogonác]

Comment on attachment 253377 [details]
Patch

LGTM, r=me 

But please add back the good change of Source/WebCore/xml/parser/XMLDocumentParserScope.h,
style checker result is misleading, you only changed 0 to nullptr, you don't need to find a
better variable name to make style checker happy.

[Hunseop Jeong]

Created attachment 253428 [details]
Patch

[WebKit Commit Bot]

Attachment 253428 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter name "structuredErrorFunc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hunseop Jeong]

Created attachment 253430 [details]
Patch

[WebKit Commit Bot]

Attachment 253430 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter name "structuredErrorFunc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hunseop Jeong]

(In reply to comment #6)
> Comment on attachment 253377 [details]
> Patch
> 
> LGTM, r=me 
> 
> But please add back the good change of
> Source/WebCore/xml/parser/XMLDocumentParserScope.h,
> style checker result is misleading, you only changed 0 to nullptr, you don't
> need to find a
> better variable name to make style checker happy.

Thanks, ossy.
I recover the original changes.
Could you give the r+ again?
I tried to add the your name to "Reviewed by" by myself.
But it looks like your name is wrong : "Reviewed by Csaba Osztrogonác."

[Csaba Osztrogonác]

Comment on attachment 253430 [details]
Patch

Mac failure is unrelated, these tests fail on trunk.

[WebKit Commit Bot]

Comment on attachment 253430 [details]
Patch

Clearing flags on attachment: 253430

Committed r184622: <http://trac.webkit.org/changeset/184622>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.