Bug 145165 - nullptr cleanup in WebCore/xml.
Summary: nullptr cleanup in WebCore/xml.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-19 02:00 PDT by Hunseop Jeong
Modified: 2015-05-20 00:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (18.94 KB, patch)
2015-05-19 02:15 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.09 KB, patch)
2015-05-19 02:34 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.48 KB, patch)
2015-05-19 22:51 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.47 KB, patch)
2015-05-19 22:58 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-05-19 02:00:54 PDT 
Replaced 0 with nullptr in WebCore/xml.
Comment 1 Hunseop Jeong 2015-05-19 02:15:17 PDT 
Created attachment 253375 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-19 02:17:26 PDT 
Attachment 253375 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter name "structuredErrorFunc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Hunseop Jeong 2015-05-19 02:34:53 PDT 
Created attachment 253377 [details]
Patch
Comment 4 Hunseop Jeong 2015-05-19 02:37:32 PDT 
(In reply to comment #2)
> Attachment 253375 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter
> name "structuredErrorFunc" adds no information, so it should be removed. 
> [readability/parameter_name] [5]
> Total errors found: 1 in 12 files
> 
Is "structuredErrorFunc" need to initialize the variable?
I removed the changes in Source/WebCore/xml/parser/XMLDocumentParserScope.h
because the style-checker inform the error.
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.
Comment 5 Csaba Osztrogonác 2015-05-19 04:22:01 PDT 
(In reply to comment #2)
> Attachment 253375 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter
> name "structuredErrorFunc" adds no information, so it should be removed. 
> [readability/parameter_name] [5]
> Total errors found: 1 in 12 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I think it is a false positive warning, you need the 
variable name to be able to add a default parameter.
Comment 6 Csaba Osztrogonác 2015-05-19 04:32:21 PDT 
Comment on attachment 253377 [details]
Patch

LGTM, r=me 

But please add back the good change of Source/WebCore/xml/parser/XMLDocumentParserScope.h,
style checker result is misleading, you only changed 0 to nullptr, you don't need to find a
better variable name to make style checker happy.
Comment 7 Hunseop Jeong 2015-05-19 22:51:41 PDT 
Created attachment 253428 [details]
Patch
Comment 8 WebKit Commit Bot 2015-05-19 22:54:09 PDT 
Attachment 253428 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter name "structuredErrorFunc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Hunseop Jeong 2015-05-19 22:58:48 PDT 
Created attachment 253430 [details]
Patch
Comment 10 WebKit Commit Bot 2015-05-19 23:00:27 PDT 
Attachment 253430 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/parser/XMLDocumentParserScope.h:48:  The parameter name "structuredErrorFunc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Hunseop Jeong 2015-05-19 23:10:23 PDT 
(In reply to comment #6)
> Comment on attachment 253377 [details]
> Patch
> 
> LGTM, r=me 
> 
> But please add back the good change of
> Source/WebCore/xml/parser/XMLDocumentParserScope.h,
> style checker result is misleading, you only changed 0 to nullptr, you don't
> need to find a
> better variable name to make style checker happy.

Thanks, ossy.
I recover the original changes.
Could you give the r+ again?
I tried to add the your name to "Reviewed by" by myself.
But it looks like your name is wrong : "Reviewed by Csaba Osztrogonác."
Comment 12 Csaba Osztrogonác 2015-05-19 23:48:58 PDT 
Comment on attachment 253430 [details]
Patch

Mac failure is unrelated, these tests fail on trunk.
Comment 13 WebKit Commit Bot 2015-05-20 00:39:20 PDT 
Comment on attachment 253430 [details]
Patch

Clearing flags on attachment: 253430

Committed r184622: <http://trac.webkit.org/changeset/184622>
Comment 14 WebKit Commit Bot 2015-05-20 00:39:23 PDT 
All reviewed patches have been landed.  Closing bug.