RESOLVED FIXED 14516
crash loading multipart/x-mixed-replace data on windows safari
https://bugs.webkit.org/show_bug.cgi?id=14516
Summary crash loading multipart/x-mixed-replace data on windows safari
Tony Chang
Reported 2007-07-03 15:20:39 PDT
When loading multipart/x-mixed-replace urls, if there's no data before the first boundary data, Safari on windows crashes (tested 3.0.2 and trunk r
Attachments
Crash on safari windows (183 bytes, text/plain)
2007-07-03 15:21 PDT, Tony Chang
no flags
null check m_resourceData (1017 bytes, patch)
2007-07-03 16:39 PDT, Tony Chang
mjs: review-
null check m_resourceData and layout test (3.75 KB, patch)
2007-07-05 18:39 PDT, Tony Chang
mjs: review+
Tony Chang
Comment 1 2007-07-03 15:21:36 PDT
Created attachment 15377 [details] Crash on safari windows
Tony Chang
Comment 2 2007-07-03 16:14:55 PDT
Hmm, it looks like my bug report got truncated. It should have said: Tested on trunk r23940. The crash is in ResourceLoader::clearResourceData() where it tries to clear m_resourceData which hasn't been initialized. This doesn't happen on Mac Safari because it first calls willStopBufferingData, which doesn't seem to be called at all by the windows resource handle. The simple fix seems to be to do a null check in clearResourceData().
Tony Chang
Comment 3 2007-07-03 16:39:25 PDT
Created attachment 15379 [details] null check m_resourceData
Alexey Proskuryakov
Comment 4 2007-07-04 02:26:08 PDT
This looks like a fix that really needs an automated test.
Maciej Stachowiak
Comment 5 2007-07-04 16:29:20 PDT
Comment on attachment 15379 [details] null check m_resourceData Good fix. Please add an http layout test (the tests in LayoutTests/http run on a local server, so you can generate multipart/x-mided-replace output). Also, please add an explanation of the bug being fixed to the ChangeLog entry. r- for now, please resubmit with these things fixed.
Tony Chang
Comment 6 2007-07-05 18:39:04 PDT
Created attachment 15410 [details] null check m_resourceData and layout test
Maciej Stachowiak
Comment 7 2007-07-05 19:26:19 PDT
Comment on attachment 15410 [details] null check m_resourceData and layout test r=me
Mark Rowe (bdash)
Comment 8 2007-07-06 03:05:10 PDT
Landed in r24053. Thanks for the patch!
Note You need to log in before you can comment on or make changes to this bug.