WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145143
Fix the build of universal binary with ARMv7k of JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=145143
Summary
Fix the build of universal binary with ARMv7k of JavaScriptCore.
Mark Lam
Reported
2015-05-18 14:27:40 PDT
Patch coming.
Attachments
the patch.
(2.23 KB, patch)
2015-05-18 14:33 PDT
,
Mark Lam
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2015-05-18 14:29:49 PDT
<
rdar://problem/20968297
>
Mark Lam
Comment 2
2015-05-18 14:33:32 PDT
Created
attachment 253344
[details]
the patch.
Geoffrey Garen
Comment 3
2015-05-18 14:42:11 PDT
Comment on
attachment 253344
[details]
the patch. r=me Would be nice to include in this comment an explanation of exactly why "if X end" has any meaning whatsoever, since it usually has no meaning.
Mark Lam
Comment 4
2015-05-19 12:33:52 PDT
Thanks for the review. I added an explanation of why this is needed to the ChangeLog. I also reversed the order of the armv7k and armv7s if statements in LowLevelInterpreter.asm to have them in alphabetical order. Landed in
r184581
: <
http://trac.webkit.org/r184581
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug