Bug 145143 - Fix the build of universal binary with ARMv7k of JavaScriptCore.
Summary: Fix the build of universal binary with ARMv7k of JavaScriptCore.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-18 14:27 PDT by Mark Lam
Modified: 2015-05-19 12:33 PDT (History)
2 users (show)

See Also:

Attachments
the patch. (2.23 KB, patch)
2015-05-18 14:33 PDT, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-05-18 14:27:40 PDT 
Patch coming.
Comment 1 Mark Lam 2015-05-18 14:29:49 PDT 
<rdar://problem/20968297>
Comment 2 Mark Lam 2015-05-18 14:33:32 PDT 
Created attachment 253344 [details]
the patch.
Comment 3 Geoffrey Garen 2015-05-18 14:42:11 PDT 
Comment on attachment 253344 [details]
the patch.

r=me

Would be nice to include in this comment an explanation of exactly why "if X end" has any meaning whatsoever, since it usually has no meaning.
Comment 4 Mark Lam 2015-05-19 12:33:52 PDT 
Thanks for the review.  I added an explanation of why this is needed to the ChangeLog.  I also reversed the order of the armv7k and armv7s if statements in LowLevelInterpreter.asm to have them in alphabetical order.

Landed in r184581: <http://trac.webkit.org/r184581>.