Bug 145139 - Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
Summary: Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-18 14:14 PDT by Joseph Pecoraro
Modified: 2015-05-18 16:31 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.50 KB, patch)
2015-05-18 14:16 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-18 14:14:11 PDT 
* SUMMARY
Improve Reliability of Closing and Reopening Elements Tab.

I was seeing an issue with an augmented DOM Agent, that closing and reopening the Elements Tab was not showing the DOM Tree child nodes of the root node. The issue seems to be that we don't show child nodes until the DOMTreeOutline is visible, but making the tree visible might not actually cause us to update and show the children again. Since we only make the tree visible once, update at that point so we are sure to add the children. It seems we luck out with web inspection through node restoration. I am not sure exactly why we work, or if it just happens to be due to lucky timing.
Comment 1 Joseph Pecoraro 2015-05-18 14:16:34 PDT 
Created attachment 253341 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-05-18 15:17:06 PDT 
Comment on attachment 253341 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253341

Committed r184515: <http://trac.webkit.org/changeset/184515>
Comment 3 WebKit Commit Bot 2015-05-18 15:17:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2015-05-18 16:31:25 PDT 
<rdar://problem/21009123>