RESOLVED FIXED145131
Give JSString a StringView getter and start using it. 
https://bugs.webkit.org/show_bug.cgi?id=145131
Summary Give JSString a StringView getter and start using it.
Andreas Kling
Reported 2015-05-18 10:17:06 PDT
JSString should have a StringView getter so that we don't always have to reify JSStrings that are secretly substrings internally.
Attachments
Patch (10.75 KB, patch)
2015-05-18 10:19 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-18 10:19:29 PDT
Created attachment 253330 [details] Patch
Darin Adler
Comment 2 2015-05-19 09:20:49 PDT
Comment on attachment 253330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253330&action=review > Source/JavaScriptCore/runtime/JSString.h:712 > + return StringView(m_value); Surprised this requires an explicit conversion. Would just returning m_value work? > Source/JavaScriptCore/runtime/JSString.h:719 > + return StringView(m_value); Surprised this requires an explicit conversion. Would just returning m_value work?
WebKit Commit Bot
Comment 3 2015-05-19 10:06:33 PDT
Comment on attachment 253330 [details] Patch Clearing flags on attachment: 253330 Committed r184575: <http://trac.webkit.org/changeset/184575>
WebKit Commit Bot
Comment 4 2015-05-19 10:06:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.