Bug 145129 – [EFL] Fix mismatched-tags warnings in UIProcess/API/efl

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

There are zillion mismatched-tags warnings in Source/WebKit2/UIProcess/API/efl,
they should be fixed to be able use clang without any build warning.

some examples:
../../Source/WebKit2/UIProcess/API/efl/ewk_view.h:217:9: warning: struct 'EwkView' was previously declared as a class [-Wmismatched-tags]
../../Source/WebKit2/UIProcess/API/efl/EwkView.h:83:1: warning: class 'EwkBackForwardList' was previously declared as a struct [-Wmismatched-tags]
../../Source/WebKit2/UIProcess/API/efl/EwkView.h:84:1: warning: class 'EwkColorPicker' was previously declared as a struct [-Wmismatched-tags]
../../Source/WebKit2/UIProcess/API/efl/EwkView.h:87:1: warning: class 'EwkPopupMenu' was previously declared as a struct [-Wmismatched-tags]
...

[Csaba Osztrogonác]

The problem is that these symbols are defined as class, but has forward
declaration / typedef as structs to be able to use them from C code too.
But it is incorrect in C++ code that's why we get this warning.

[Csaba Osztrogonác]

Created attachment 253326 [details]
Patch

I'm not 100% sure if it is the best fix for this issue, but don't have better idea.

[Gyuyoung Kim]

(In reply to comment #2)
> Created attachment 253326 [details]
> Patch
> 
> I'm not 100% sure if it is the best fix for this issue, but don't have
> better idea.

I considered to add EflTypedefs.h defined in WTF though, now this patch touches public APIs. So I'm not sure if this approach is nice way too.

http://trac.webkit.org/browser/trunk/Source/WTF/wtf/efl/EflTypedefs.h

If we add EWKTypedefs.h in EFL WK2, many ewk_public header files should include the EWKTypedefs.h.

[Gyuyoung Kim]

Comment on attachment 253326 [details]
Patch

Nobody has better idea to solve this issue. Let's go ahead.

[WebKit Commit Bot]

Comment on attachment 253326 [details]
Patch

Clearing flags on attachment: 253326

Committed r184710: <http://trac.webkit.org/changeset/184710>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.