RESOLVED FIXED 145125
Suppress null-conversion warnings in ANGLE 
https://bugs.webkit.org/show_bug.cgi?id=145125
Summary Suppress null-conversion warnings in ANGLE
Csaba Osztrogonác
Reported 2015-05-18 03:28:59 PDT
./glslang_lex.cpp:1282:84: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2463:83: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2490:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2640:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2649:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2665:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2673:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2857:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2870:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2932:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2947:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:3112:82: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] 12 warnings generated. ./Tokenizer.cpp:848:84: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1604:83: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1631:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1781:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1790:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1806:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1814:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1998:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2011:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2073:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2088:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2253:82: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] 12 warnings generated. We should fix it after ANGLE update - bug145010 .
Attachments
Patch (1.45 KB, patch)
2015-06-18 05:57 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-05-20 09:58:53 PDT
I assume this is from gcc. Is there an equivalent of #pragma clang diagnostic ignored "-Wnull-conversion"? I don't think we want to actually change this generated code.
Csaba Osztrogonác
Comment 2 2015-05-21 01:42:44 PDT
No, it is clang warning.
Csaba Osztrogonác
Comment 3 2015-06-18 05:56:08 PDT
Let's suppress this warning instead of changing 3rdparty source.
Csaba Osztrogonác
Comment 4 2015-06-18 05:57:23 PDT
Created attachment 255110 [details] Patch
WebKit Commit Bot
Comment 5 2015-06-18 10:55:51 PDT
Comment on attachment 255110 [details] Patch Clearing flags on attachment: 255110 Committed r185707: <http://trac.webkit.org/changeset/185707>
WebKit Commit Bot
Comment 6 2015-06-18 10:55:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.