WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145118
REGRESSION(
r180910
) Fullscreen video does not display on platforms without accelerated video rendering
https://bugs.webkit.org/show_bug.cgi?id=145118
Summary
REGRESSION(r180910) Fullscreen video does not display on platforms without ac...
daegyu.lee@navercorp.com
Reported
2015-05-18 00:35:26 PDT
Created
attachment 253307
[details]
not shown fullscreen video I think this is the regression of
r180910
. Reproduce site :
http://www.w3schools.com/html/html5_video.asp
Attachments
not shown fullscreen video
(12.49 KB, image/png)
2015-05-18 00:35 PDT
,
daegyu.lee@navercorp.com
no flags
Details
patch
(1.62 KB, patch)
2015-05-18 01:54 PDT
,
daegyu.lee@navercorp.com
no flags
Details
Formatted Diff
Diff
patch
(1.59 KB, patch)
2015-05-18 02:01 PDT
,
daegyu.lee@navercorp.com
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
daegyu.lee@navercorp.com
Comment 1
2015-05-18 01:54:26 PDT
Created
attachment 253312
[details]
patch
WebKit Commit Bot
Comment 2
2015-05-18 01:56:27 PDT
Attachment 253312
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
daegyu.lee@navercorp.com
Comment 3
2015-05-18 02:01:32 PDT
Created
attachment 253313
[details]
patch
Gyuyoung Kim
Comment 4
2015-05-20 23:51:15 PDT
Comment on
attachment 253313
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=253313&action=review
> Source/WebCore/rendering/RenderVideo.cpp:191 > + else if (!videoElement().isFullscreen() || !mediaPlayer->supportsAcceleratedRendering()) {
Can't we add or reproduce test for this issue ?
daegyu.lee@navercorp.com
Comment 5
2015-05-21 00:13:53 PDT
This is the regression of
r180910
.
https://bugs.webkit.org/show_bug.cgi?id=142097
This patch won't affect rending on platforms without accelerated video rendering.
WebKit Commit Bot
Comment 6
2015-05-26 14:37:57 PDT
Comment on
attachment 253313
[details]
patch Clearing flags on attachment: 253313 Committed
r184875
: <
http://trac.webkit.org/changeset/184875
>
WebKit Commit Bot
Comment 7
2015-05-26 14:38:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug