Bug 145118 – REGRESSION(r180910) Fullscreen video does not display on platforms without accelerated video rendering

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[[e-mail]]

Created attachment 253307 [details]
not shown fullscreen video

I think this is the regression of r180910.
Reproduce site : http://www.w3schools.com/html/html5_video.asp

[[e-mail]]

Created attachment 253312 [details]
patch

[WebKit Commit Bot]

Attachment 253312 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[[e-mail]]

Created attachment 253313 [details]
patch

[Gyuyoung Kim]

Comment on attachment 253313 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253313&action=review

> Source/WebCore/rendering/RenderVideo.cpp:191
> +    else if (!videoElement().isFullscreen() || !mediaPlayer->supportsAcceleratedRendering()) {

Can't we add or reproduce test for this issue ?

[[e-mail]]

This is the regression of r180910.
https://bugs.webkit.org/show_bug.cgi?id=142097

This patch won't affect rending on platforms without accelerated video rendering.

[WebKit Commit Bot]

Comment on attachment 253313 [details]
patch

Clearing flags on attachment: 253313

Committed r184875: <http://trac.webkit.org/changeset/184875>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.