Bug 145118 - REGRESSION(r180910) Fullscreen video does not display on platforms without accelerated video rendering
Summary: REGRESSION(r180910) Fullscreen video does not display on platforms without ac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: daegyu.lee@navercorp.com
URL:
Keywords:
Depends on: 142097
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-18 00:35 PDT by daegyu.lee@navercorp.com
Modified: 2015-05-26 14:38 PDT (History)
5 users (show)

See Also:


Attachments
not shown fullscreen video (12.49 KB, image/png)
2015-05-18 00:35 PDT, daegyu.lee@navercorp.com
no flags Details
patch (1.62 KB, patch)
2015-05-18 01:54 PDT, daegyu.lee@navercorp.com
no flags Details | Formatted Diff | Diff
patch (1.59 KB, patch)
2015-05-18 02:01 PDT, daegyu.lee@navercorp.com
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daegyu.lee@navercorp.com 2015-05-18 00:35:26 PDT
Created attachment 253307 [details]
not shown fullscreen video

I think this is the regression of r180910.
Reproduce site : http://www.w3schools.com/html/html5_video.asp
Comment 1 daegyu.lee@navercorp.com 2015-05-18 01:54:26 PDT
Created attachment 253312 [details]
patch
Comment 2 WebKit Commit Bot 2015-05-18 01:56:27 PDT
Attachment 253312 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 daegyu.lee@navercorp.com 2015-05-18 02:01:32 PDT
Created attachment 253313 [details]
patch
Comment 4 Gyuyoung Kim 2015-05-20 23:51:15 PDT
Comment on attachment 253313 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253313&action=review

> Source/WebCore/rendering/RenderVideo.cpp:191
> +    else if (!videoElement().isFullscreen() || !mediaPlayer->supportsAcceleratedRendering()) {

Can't we add or reproduce test for this issue ?
Comment 5 daegyu.lee@navercorp.com 2015-05-21 00:13:53 PDT
This is the regression of r180910.
https://bugs.webkit.org/show_bug.cgi?id=142097

This patch won't affect rending on platforms without accelerated video rendering.
Comment 6 WebKit Commit Bot 2015-05-26 14:37:57 PDT
Comment on attachment 253313 [details]
patch

Clearing flags on attachment: 253313

Committed r184875: <http://trac.webkit.org/changeset/184875>
Comment 7 WebKit Commit Bot 2015-05-26 14:38:01 PDT
All reviewed patches have been landed.  Closing bug.