RESOLVED FIXED 145117
[GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/ 
https://bugs.webkit.org/show_bug.cgi?id=145117
Summary [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
Zan Dobersek
Reported 2015-05-18 00:28:37 PDT
[GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
Attachments
Patch (27.14 KB, patch)
2015-05-18 00:34 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (35.15 KB, patch)
2015-05-18 00:45 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-05-18 00:34:33 PDT
Created attachment 253306 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-18 00:37:46 PDT
Attachment 253306 [details] did not pass style-queue: ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:113: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:92: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:118: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:125: More than one command on the same line [whitespace/newline] [4] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2015-05-18 00:45:44 PDT
Created attachment 253308 [details] Patch
WebKit Commit Bot
Comment 4 2015-05-18 00:48:54 PDT
Attachment 253308 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:58: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:113: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:92: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:118: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:125: More than one command on the same line [whitespace/newline] [4] Total errors found: 8 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 5 2015-05-18 01:32:54 PDT
Comment on attachment 253308 [details] Patch LGTM, rs=me
Carlos Garcia Campos
Comment 6 2015-05-18 22:55:22 PDT
Cool, thanks!
Zan Dobersek
Comment 7 2015-05-20 22:55:29 PDT
Comment on attachment 253308 [details] Patch Clearing flags on attachment: 253308 Committed r184703: <http://trac.webkit.org/changeset/184703>
Zan Dobersek
Comment 8 2015-05-20 22:55:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.