Bug 145117 - [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
Summary: [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-18 00:28 PDT by Zan Dobersek
Modified: 2015-05-20 22:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (27.14 KB, patch)
2015-05-18 00:34 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (35.15 KB, patch)
2015-05-18 00:45 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-05-18 00:28:37 PDT 
[GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
Comment 1 Zan Dobersek 2015-05-18 00:34:33 PDT 
Created attachment 253306 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-18 00:37:46 PDT 
Attachment 253306 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:113:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:87:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:92:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:118:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:125:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2015-05-18 00:45:44 PDT 
Created attachment 253308 [details]
Patch
Comment 4 WebKit Commit Bot 2015-05-18 00:48:54 PDT 
Attachment 253308 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:58:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:113:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:87:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:92:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:118:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:125:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 8 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Csaba Osztrogonác 2015-05-18 01:32:54 PDT 
Comment on attachment 253308 [details]
Patch

LGTM, rs=me
Comment 6 Carlos Garcia Campos 2015-05-18 22:55:22 PDT 
Cool, thanks!
Comment 7 Zan Dobersek 2015-05-20 22:55:29 PDT 
Comment on attachment 253308 [details]
Patch

Clearing flags on attachment: 253308

Committed r184703: <http://trac.webkit.org/changeset/184703>
Comment 8 Zan Dobersek 2015-05-20 22:55:39 PDT 
All reviewed patches have been landed.  Closing bug.