Bug 145113 – Source/WTF/wtf/Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 for mips N64

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[YunQiang Su]

Index: webkit2gtk-2.8.1+dfsg1/Source/WTF/wtf/Platform.h
===================================================================
--- webkit2gtk-2.8.1+dfsg1.orig/Source/WTF/wtf/Platform.h       2015-05-03 00:05:21.000000000 +0800
+++ webkit2gtk-2.8.1+dfsg1/Source/WTF/wtf/Platform.h    2015-05-04 00:30:23.858545576 +0800
@@ -82,7 +82,7 @@

 /* CPU(MIPS) - MIPS 32-bit and 64-bit */
 #if (defined(mips) || defined(__mips__) || defined(MIPS) || defined(_MIPS_) || defined(__mips64))
-#if defined(_MIPS_SIM_ABI64) && (_MIPS_SIM == _MIPS_SIM_ABI64)
+#if defined(_ABI64) && (_MIPS_SIM == _ABI64)
 #define WTF_CPU_MIPS64 1
 #define WTF_MIPS_ARCH __mips64
 #else


Please replace _MIPS_SIM_ABI64 with _ABI64, as _ABI64 is much more widely used,
and is defined by compilers, while 
_MIPS_SIM_ABI64 is only defined by glibc.

[YunQiang Su]

Any one worked on this ?

[Csaba Osztrogonác]

I don't think if anyone maintains MIPS specific code paths.

[YunQiang Su]

OK.
Can you help to commit this patch?

We tested this patch. It works well.

[Csaba Osztrogonác]

(In reply to comment #3)
> OK.
> Can you help to commit this patch?
> 
> We tested this patch. It works well.

Please upload the patch for review (for trunk WebKit) 
with the necessary changelog entry. And then I can
review and commit it to WebKit trunk and Carlos can
land it to the GTK release branch.

[YunQiang Su]

Created attachment 255357 [details]
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64

[Csaba Osztrogonác]

Comment on attachment 255357 [details]
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64

r=me, but will land manually because of missing "Reviewed by nobody" line.

[Csaba Osztrogonác]

Comment on attachment 255357 [details]
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64

View in context: https://bugs.webkit.org/attachment.cgi?id=255357&action=review

> ChangeLog:5
> [phone]  YunQiang Su  <[e-mail]>
> +
> +        [WTF] Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64
> +        https://bugs.webkit.org/show_bug.cgi?id=145113
> +

It should be in Source/WTF/ChangeLog.

[Csaba Osztrogonác]

Committed r185863: <http://trac.webkit.org/changeset/185863>