Bug 145113 - Source/WTF/wtf/Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 for mips N64
Summary: Source/WTF/wtf/Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 for mips N64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-17 19:00 PDT by YunQiang Su
Modified: 2015-06-22 23:34 PDT (History)
5 users (show)

See Also:


Attachments
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64 (926 bytes, patch)
2015-06-22 11:44 PDT, YunQiang Su
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description YunQiang Su 2015-05-17 19:00:02 PDT
Index: webkit2gtk-2.8.1+dfsg1/Source/WTF/wtf/Platform.h
===================================================================
--- webkit2gtk-2.8.1+dfsg1.orig/Source/WTF/wtf/Platform.h       2015-05-03 00:05:21.000000000 +0800
+++ webkit2gtk-2.8.1+dfsg1/Source/WTF/wtf/Platform.h    2015-05-04 00:30:23.858545576 +0800
@@ -82,7 +82,7 @@

 /* CPU(MIPS) - MIPS 32-bit and 64-bit */
 #if (defined(mips) || defined(__mips__) || defined(MIPS) || defined(_MIPS_) || defined(__mips64))
-#if defined(_MIPS_SIM_ABI64) && (_MIPS_SIM == _MIPS_SIM_ABI64)
+#if defined(_ABI64) && (_MIPS_SIM == _ABI64)
 #define WTF_CPU_MIPS64 1
 #define WTF_MIPS_ARCH __mips64
 #else


Please replace _MIPS_SIM_ABI64 with _ABI64, as _ABI64 is much more widely used,
and is defined by compilers, while 
_MIPS_SIM_ABI64 is only defined by glibc.
Comment 1 YunQiang Su 2015-06-22 00:50:23 PDT
Any one worked on this ?
Comment 2 Csaba Osztrogonác 2015-06-22 00:52:35 PDT
I don't think if anyone maintains MIPS specific code paths.
Comment 3 YunQiang Su 2015-06-22 00:56:43 PDT
OK.
Can you help to commit this patch?

We tested this patch. It works well.
Comment 4 Csaba Osztrogonác 2015-06-22 01:01:19 PDT
(In reply to comment #3)
> OK.
> Can you help to commit this patch?
> 
> We tested this patch. It works well.

Please upload the patch for review (for trunk WebKit) 
with the necessary changelog entry. And then I can
review and commit it to WebKit trunk and Carlos can
land it to the GTK release branch.
Comment 5 YunQiang Su 2015-06-22 11:44:57 PDT
Created attachment 255357 [details]
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64
Comment 6 Csaba Osztrogonác 2015-06-22 23:30:57 PDT
Comment on attachment 255357 [details]
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64

r=me, but will land manually because of missing "Reviewed by nobody" line.
Comment 7 Csaba Osztrogonác 2015-06-22 23:32:10 PDT
Comment on attachment 255357 [details]
Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64

View in context: https://bugs.webkit.org/attachment.cgi?id=255357&action=review

> ChangeLog:5
> +2015-06-22  YunQiang Su  <wzssyqa@gmail.com>
> +
> +        [WTF] Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64
> +        https://bugs.webkit.org/show_bug.cgi?id=145113
> +

It should be in Source/WTF/ChangeLog.
Comment 8 Csaba Osztrogonác 2015-06-22 23:34:07 PDT
Committed r185863: <http://trac.webkit.org/changeset/185863>