Bug 145094 - Add getElementById to DocumentFragment
Summary: Add getElementById to DocumentFragment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-15 22:48 PDT by Sam Weinig
Modified: 2015-05-16 11:50 PDT (History)
0 users

See Also:

Attachments
Patch (15.26 KB, patch)
2015-05-15 22:55 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (15.72 KB, patch)
2015-05-16 09:42 PDT, Sam Weinig 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-05-15 22:48:44 PDT 
Add getElementById to DocumentFragment
Comment 1 Sam Weinig 2015-05-15 22:55:14 PDT 
Created attachment 253266 [details]
Patch
Comment 2 Sam Weinig 2015-05-16 09:42:56 PDT 
Created attachment 253270 [details]
Patch
Comment 3 Alexey Proskuryakov 2015-05-16 11:14:02 PDT 
Comment on attachment 253270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253270&action=review

> Source/WebCore/dom/DocumentFragment.cpp:97
> +    // Add fast path for ShadowRoot, where we are both a DocumentFragment and a TreeScope.

S/Add// ?

> Source/WebCore/dom/DocumentFragment.cpp:101
> +    // Otherwise, fallback to iterating all of the element descendants.

"Fall back" should be with a space here I think.
Comment 4 Sam Weinig 2015-05-16 11:18:02 PDT 
Committed revision 184435.
Comment 5 Darin Adler 2015-05-16 11:50:03 PDT 
Comment on attachment 253270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253270&action=review

> Source/WebCore/dom/NonElementParentNode.idl:31
> +    Element getElementById([Default=Undefined,ObjCExplicitAtomicString,RequiresExistingAtomicString] optional DOMString elementId);

Spaces after commas please.