Bug 145084 - Web Inspector: Timeline data grid displays wrong records after switching between Timelines/Frames mode
Summary: Web Inspector: Timeline data grid displays wrong records after switching betw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-15 17:28 PDT by Matt Baker
Modified: 2015-05-15 20:01 PDT (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (3.27 KB, patch)
2015-05-15 18:19 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-05-15 17:28:12 PDT
* SUMMARY
Timeline data grid displays wrong records after switching between Timelines/Frames mode.

The selected region of the graph is correct after switching between the two view modes. It looks like the data grid is using the selection from the wrong timeline ruler.

* STEPS TO REPRODUCE
1. Open Inspector, record some timeline data
2. Make a selection in the Timelines overview graph
3. Switch to the Rendering Frames view
4. Make a selection in the Rendering Frames overview graph
5. Switch back to the Timelines view
  => The graph selection is restored correctly, but the grid shows the wrong records (or no records).
Comment 1 Radar WebKit Bug Importer 2015-05-15 17:28:25 PDT
<rdar://problem/20985091>
Comment 2 Matt Baker 2015-05-15 18:19:32 PDT
Created attachment 253251 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2015-05-15 19:48:29 PDT
Comment on attachment 253251 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253251&action=review

r=me, nice!

> Source/WebInspectorUI/ChangeLog:14
> +        (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
> +        (WebInspector.TimelineSidebarPanel.get else):
> +        (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
> +        (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):

Yikes, clean these signatures up a bit before landing if you can. I clearly made some mistake in prepare-ChangeLog's class parsing logic.
Comment 4 WebKit Commit Bot 2015-05-15 20:01:35 PDT
Comment on attachment 253251 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 253251

Committed r184427: <http://trac.webkit.org/changeset/184427>
Comment 5 WebKit Commit Bot 2015-05-15 20:01:48 PDT
All reviewed patches have been landed.  Closing bug.