Bug 145076 - REGRESSION (r181910): WKWebView incorrectly scales snapshot
Summary: REGRESSION (r181910): WKWebView incorrectly scales snapshot
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 143023
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-15 15:36 PDT by James Savage
Modified: 2015-05-15 17:23 PDT (History)
2 users (show)

See Also:


Attachments
Correct the scale and transform used for IOSurface snapshots. (3.47 KB, patch)
2015-05-15 15:43 PDT, James Savage
no flags Details | Formatted Diff | Diff
Updated change log (3.89 KB, patch)
2015-05-15 15:56 PDT, James Savage
thorton: review+
Details | Formatted Diff | Diff
Updated for review feedback. (3.91 KB, patch)
2015-05-15 16:08 PDT, James Savage
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Savage 2015-05-15 15:36:10 PDT
We are always assuming that the ratio between snapshot rect size and snapshot size will be device scale, which is not always correct.
Comment 1 James Savage 2015-05-15 15:43:59 PDT
Created attachment 253231 [details]
Correct the scale and transform used for IOSurface snapshots.
Comment 2 James Savage 2015-05-15 15:45:24 PDT
rdar://19816542
Comment 3 James Savage 2015-05-15 15:56:55 PDT
Created attachment 253232 [details]
Updated change log
Comment 4 Tim Horton 2015-05-15 15:59:40 PDT
Comment on attachment 253232 [details]
Updated change log

View in context: https://bugs.webkit.org/attachment.cgi?id=253232&action=review

> Source/WebKit2/ChangeLog:3
> +        Web view snapshots incorrectly scale transform

Title should probably start with "REGRESSION (r181910):", and maybe WKWebView instead of "Web view" and "snapshot" instead of "transform"?
Comment 5 James Savage 2015-05-15 16:08:18 PDT
Created attachment 253233 [details]
Updated for review feedback.
Comment 6 James Savage 2015-05-15 16:24:58 PDT
Whoops, this is actually rdar://problem/20410944.
Comment 7 WebKit Commit Bot 2015-05-15 16:28:42 PDT
Comment on attachment 253233 [details]
Updated for review feedback.

Rejecting attachment 253233 [details] from commit-queue.

james.savage@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 8 WebKit Commit Bot 2015-05-15 17:23:16 PDT
Comment on attachment 253233 [details]
Updated for review feedback.

Clearing flags on attachment: 253233

Committed r184422: <http://trac.webkit.org/changeset/184422>