Bug 145072 - Move HTMLElement's children property to ParentNode
Summary: Move HTMLElement's children property to ParentNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-15 14:09 PDT by Sam Weinig
Modified: 2015-05-15 15:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.47 KB, patch)
2015-05-15 14:17 PDT, Sam Weinig
cdumez: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (566.76 KB, application/zip)
2015-05-15 15:06 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-mavericks (596.74 KB, application/zip)
2015-05-15 15:24 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-05-15 14:09:10 PDT
Move HTMLElement's children property to ParentNode
Comment 1 Sam Weinig 2015-05-15 14:17:20 PDT
Created attachment 253223 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-15 14:19:22 PDT
Attachment 253223 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ContainerNode.cpp:944:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2015-05-15 15:06:50 PDT
Comment on attachment 253223 [details]
Patch

Attachment 253223 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5261873276518400

New failing tests:
js/dom/dom-static-property-for-in-iteration.html
Comment 4 Build Bot 2015-05-15 15:06:53 PDT
Created attachment 253225 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 5 Chris Dumez 2015-05-15 15:11:51 PDT
Comment on attachment 253223 [details]
Patch

r=me! (with layout test rebaseline)
Comment 6 Chris Dumez 2015-05-15 15:12:39 PDT
Comment on attachment 253223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253223&action=review

> Source/WebCore/dom/ContainerNode.cpp:946
> +    } else if (type == SelectOptions) {

Also the style script is right that we shouldn't use "else" here and below.
Comment 7 Build Bot 2015-05-15 15:24:46 PDT
Comment on attachment 253223 [details]
Patch

Attachment 253223 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6251226509344768

New failing tests:
js/dom/dom-static-property-for-in-iteration.html
Comment 8 Build Bot 2015-05-15 15:24:50 PDT
Created attachment 253229 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 9 Sam Weinig 2015-05-15 15:58:02 PDT
Committed revision 184420.