Bug 145072 – Move HTMLElement's children property to ParentNode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Move HTMLElement's children property to ParentNode

[Sam Weinig]

Created attachment 253223 [details]
Patch

[WebKit Commit Bot]

Attachment 253223 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ContainerNode.cpp:944:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 253223 [details]
Patch

Attachment 253223 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5261873276518400

New failing tests:
js/dom/dom-static-property-for-in-iteration.html

[Build Bot]

Created attachment 253225 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Chris Dumez]

Comment on attachment 253223 [details]
Patch

r=me! (with layout test rebaseline)

[Chris Dumez]

Comment on attachment 253223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253223&action=review

> Source/WebCore/dom/ContainerNode.cpp:946
> +    } else if (type == SelectOptions) {

Also the style script is right that we shouldn't use "else" here and below.

[Build Bot]

Comment on attachment 253223 [details]
Patch

Attachment 253223 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6251226509344768

New failing tests:
js/dom/dom-static-property-for-in-iteration.html

[Build Bot]

Created attachment 253229 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Sam Weinig]

Committed revision 184420.