Bug 145067 - Web Inspector: Initiator Popovers no longer work in Layout Timeline
Summary: Web Inspector: Initiator Popovers no longer work in Layout Timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-05-15 12:30 PDT by Joseph Pecoraro
Modified: 2015-05-15 13:47 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.40 KB, patch)
2015-05-15 12:32 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-15 12:30:56 PDT 
* SUMMARY
Initiator Popovers no longer work in Layout Timeline.

The anchor finder is returning null:

    callFramePopoverAnchorElement: function()
    {
        return this.selectedNode.elementWithColumnIdentifier("initiatorCallFrame");
    }

Because "initiatorCallFrame" changed to "location".

There was a console.assert that caught this.
Comment 1 Joseph Pecoraro 2015-05-15 12:32:20 PDT 
Created attachment 253216 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-05-15 13:47:41 PDT 
Comment on attachment 253216 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253216

Committed r184410: <http://trac.webkit.org/changeset/184410>
Comment 3 WebKit Commit Bot 2015-05-15 13:47:45 PDT 
All reviewed patches have been landed.  Closing bug.