Bug 145066 – Web Inspector: Reduce type annotation update frequency

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Reduce type annotation update frequency.

I was seeing Runtime.getRuntimeTypesForVariablesAtOffsets happening every 16-24ms in the case where nothing is changing. That is unnecessarily frequent. Lets reduction this to 100ms - 2000ms (worst case).

[Joseph Pecoraro]

Created attachment 253215 [details]
[PATCH] Proposed Fix

[Saam Barati]

Comment on attachment 253215 [details]
[PATCH] Proposed Fix

Looks good to me. 
At some point I work on the patch that makes it so we only
update when we need to. This would have the consequence
of never updating when code stops running which would be
a big win.

[Saam Barati]

(In reply to comment #0)
> * SUMMARY
> Reduce type annotation update frequency.
> 
> I was seeing Runtime.getRuntimeTypesForVariablesAtOffsets happening every
> 16-24ms in the case where nothing is changing. That is unnecessarily
> frequent. Lets reduction this to 100ms - 2000ms (worst case).

It looks like the code has the maximum at 1000, not sure if you want
to make it 2000 or keep it at 1000

[Timothy Hatcher]

Comment on attachment 253215 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253215&action=review

> Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js:71
> +            var timeoutTime = Math.max(100, Math.min(1000, 8 * totalTime));

ChangeLog says 2000, code says 1000.

[Joseph Pecoraro]

(In reply to comment #4)
> Comment on attachment 253215 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253215&action=review
> 
> > Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js:71
> > +            var timeoutTime = Math.max(100, Math.min(1000, 8 * totalTime));
> 
> ChangeLog says 2000, code says 1000.

Oops. I'll make it 2000. At one point I did see a 1.2s being possible.

[Joseph Pecoraro]

Created attachment 253220 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 253220 [details]
[PATCH] For Landing

Clearing flags on attachment: 253220

Committed r184418: <http://trac.webkit.org/changeset/184418>