Bug 145065 – Prefix force on MouseEvent and add constants for click and force click values

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Beth Dakin]

Prefix force on MouseEvent and add constants for click and force click values

rdar://problem/20770052

[Beth Dakin]

Created attachment 253211 [details]
Patch

[WebKit Commit Bot]

Attachment 253211 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.h:52:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/MouseEvent.h:53:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 253211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253211&action=review

> Source/WebCore/dom/MouseEvent.h:95
>      double force() const { return m_force; }
> +    double webkitForce() const { return m_force; }

Isn't there a way in the IDL to have an alias like this without having to have the function twice?

[Tim Horton]

(In reply to comment #3)
> Comment on attachment 253211 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253211&action=review
> 
> > Source/WebCore/dom/MouseEvent.h:95
> >      double force() const { return m_force; }
> > +    double webkitForce() const { return m_force; }
> 
> Isn't there a way in the IDL to have an alias like this without having to
> have the function twice?

Yes! I think you want something like this:

[Conditional=MOUSE_FORCE_EVENTS, ImplementedAs=force] readonly attribute double webkitForce;

[Beth Dakin]

Thanks, Tim! http://trac.webkit.org/changeset/184417