Bug 145063 - AudioContext should resolve promises with jsUndefined() and not jsNull()
Summary: AudioContext should resolve promises with jsUndefined() and not jsNull()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-15 11:35 PDT by youenn fablet
Modified: 2015-05-19 14:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2015-05-15 12:01 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-05-15 11:35:14 PDT 
AudioContext resume, suspend and close are all returning promises.
Resolving these promises is done by passing a null value, while there should be no value passed at all, therefore passing undefined.
Comment 1 youenn fablet 2015-05-15 12:01:01 PDT 
Created attachment 253212 [details]
Patch
Comment 2 Jer Noble 2015-05-15 13:21:47 PDT 
What do other browsers do for Promise<void>?
Comment 3 youenn fablet 2015-05-15 13:45:30 PDT 
Chromium is going the undefined way.
Not sure about Mozilla and IE.
Comment 4 youenn fablet 2015-05-15 13:46:31 PDT 
(In reply to comment #3)
> Chromium is going the undefined way.
> Not sure about Mozilla and IE.

Also, in the streams API, we are going with undefined as well when resolving the close promise.
Comment 5 Darin Adler 2015-05-19 08:39:06 PDT 
Sam, can you make the call on this?
Comment 6 Sam Weinig 2015-05-19 12:58:26 PDT 
Comment on attachment 253212 [details]
Patch

Seems fine. r=me.
Comment 7 WebKit Commit Bot 2015-05-19 14:12:28 PDT 
Comment on attachment 253212 [details]
Patch

Clearing flags on attachment: 253212

Committed r184588: <http://trac.webkit.org/changeset/184588>
Comment 8 WebKit Commit Bot 2015-05-19 14:12:34 PDT 
All reviewed patches have been landed.  Closing bug.