Bug 145060 - Checkmark on OFF option of captions sometimes does not appear
Summary: Checkmark on OFF option of captions sometimes does not appear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-15 10:04 PDT by Roger Fong
Modified: 2015-05-15 11:00 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.84 KB, patch)
2015-05-15 10:12 PDT, Roger Fong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-05-15 10:04:57 PDT 
<rdar://problem/19388333>

Only happens when we have both audio tracks and subtitle options
Comment 1 Roger Fong 2015-05-15 10:12:24 PDT 
Created attachment 253205 [details]
patch
Comment 2 Roger Fong 2015-05-15 10:18:45 PDT 
Note that the var trackMenuItemSelected = true;
results in the OFF menu logic for subtitles not being trigger ever.
Comment 3 WebKit Commit Bot 2015-05-15 10:59:56 PDT 
Comment on attachment 253205 [details]
patch

Clearing flags on attachment: 253205

Committed r184396: <http://trac.webkit.org/changeset/184396>
Comment 4 WebKit Commit Bot 2015-05-15 11:00:00 PDT 
All reviewed patches have been landed.  Closing bug.