Bug 145041 – AX: Select text mechanism returns results outside of text control regions

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

INSTRUCTIONS:
1. Enable Enhanced Dictation in System Preferences>Dictation & Speech
2. Enable Advanced Commands in System Preferences>Accessibility>Dictation>Dictation Commands
3. Open Safari and go to LinkedIn.com
4. Place cursor in search area and activate dictation with fn-fn.
5. Say "The quick brown fox"
6. Say "Show commands window"
7. Randomly select and say navigation and selection commands


This is because the select-text mechanism should only return results within a text control when the search is within a text control

[Radar WebKit Bug Importer]

<rdar://problem/20970909>

[chris fleizach]

<rdar://problem/18181921>

[chris fleizach]

Created attachment 253179 [details]
patch

[Mario Sanchez Prada]

Comment on attachment 253179 [details]
patch

The bug title was a bit misleading to me at the beginning, since it says "editable text area regions" while the patch is specific to text controls in forms.

After reviewing the patch, I think it makes sense to limit this to text controls and not to all editable text regions (e.g. contenteditable="true"), as you don't normally want to mix/merge the text from inside those controls with the text from the rest of the page. But perhaps changing the bug title and updating the changelog before landing could be a nice thing to do too, if it's not too much of a trouble.

[chris fleizach]

Thanks

http://trac.webkit.org/changeset/184563