Bug 145030 – Rename connectionDidClose and related methods to be more clear

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Rename connectionDidClose and related methods to be more clear

When reading code in the UIProcess, it is easy to confuse "connectionDidClose(IPC::Connection)" and "didClose(IPC::Connection)"

The former means "the UI Process is purposefully shutting down the connection to a child process.

The later means "the remote end point of this connection has gone away"

We should leave the later, but change the former to be much more explicit.

[Brady Eidson]

Blocking https://bugs.webkit.org/show_bug.cgi?id=144971

[Brady Eidson]

Created attachment 253157 [details]
Patch v1

[Brady Eidson]

Created attachment 253158 [details]
Patch

[Brady Eidson]

Created attachment 253159 [details]
Patch v2 - Even better naming

[Darin Adler]

Comment on attachment 253159 [details]
Patch v2 - Even better naming

View in context: https://bugs.webkit.org/attachment.cgi?id=253159&action=review

The phrase “web process shutting down’ seems to be missing a verb; the tense is confusing, like intentional strangeness of the movie title Rachel Getting Married.

How about “web process will shut down” or “web process is shutting down” or “web process did shut down”? Or whatever the actual situation is.

> Source/WebKit2/Shared/ChildProcessProxy.h:76
> +    void shutdownProcess();

The verb is two words “shut down”, so this should be shutDownProcess.

> Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:77
> +    ASSERT(this->connection() == &connection);

This should use ASSERT_UNUSED.

> Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:100
> +    ASSERT(this->connection() == &connection);

This should use ASSERT_UNUSED.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:87
> +    ASSERT(this->connection() == &connection);

This should use ASSERT_UNUSED.

> Source/WebKit2/UIProcess/WebProcessProxy.h:164
> +    void shutdown();

Again, the verb “shut down” is two words and this should be shutDown.

[Brady Eidson]

Great suggestions. Thanks for the review!

[Brady Eidson]

http://trac.webkit.org/changeset/184370