RESOLVED FIXED 145022
Add a layout mode that scales down the view to try to fit the document 
https://bugs.webkit.org/show_bug.cgi?id=145022
Summary Add a layout mode that scales down the view to try to fit the document
Tim Horton
Reported 2015-05-14 15:11:10 PDT
Add a layout mode that scales down the view to try to fit the document
Attachments
Patch (22.28 KB, patch)
2015-05-14 15:11 PDT, Tim Horton 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-05-14 15:11:38 PDT
Created attachment 253149 [details] Patch
Dean Jackson
Comment 2 2015-05-14 15:15:25 PDT
Comment on attachment 253149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253149&action=review > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:278 > + const int maximumDocumentWidthForScaling = 1440; > + const float minimumViewScale = 0.1; Aren't these defined elsewhere? > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:304 > + viewScale = (float)viewWidth / (float)documentWidth; Can documentWidth ever be zero?
Tim Horton
Comment 3 2015-05-14 15:17:54 PDT
(In reply to comment #2) > Comment on attachment 253149 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253149&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:278 > > + const int maximumDocumentWidthForScaling = 1440; > > + const float minimumViewScale = 0.1; > > Aren't these defined elsewhere? Not for this mechanism, no. > > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:304 > > + viewScale = (float)viewWidth / (float)documentWidth; > > Can documentWidth ever be zero? Probably. We should probably not even try to do anything in that case. Will fix. Thanks!
Tim Horton
Comment 4 2015-05-14 15:48:14 PDT
https://trac.webkit.org/changeset/184358
Note You need to log in before you can comment on or make changes to this bug.