Bug 145021 - [CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation
Summary: [CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2015-05-14 15:03 PDT by Manuel Rego Casasnovas
Modified: 2015-05-17 23:17 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.13 KB, patch)
2015-05-14 15:04 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2015-05-14 15:03:07 PDT
Currently there's the following FIXME in RenderGrid::computeIntrinsicLogicalWidths():
        // FIXME: This should add in the scrollbarWidth (e.g. see RenderFlexibleBox).

We should add the scrollbar width when we calculate the intrinsic with of the grid container.
Comment 1 Manuel Rego Casasnovas 2015-05-14 15:04:56 PDT
Created attachment 253148 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-17 23:17:05 PDT
Comment on attachment 253148 [details]
Patch

Clearing flags on attachment: 253148

Committed r184446: <http://trac.webkit.org/changeset/184446>
Comment 3 WebKit Commit Bot 2015-05-17 23:17:12 PDT
All reviewed patches have been landed.  Closing bug.