Bug 145017 - Local storage origins should include origins with transient local storage
Summary: Local storage origins should include origins with transient local storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-14 13:32 PDT by Anders Carlsson
Modified: 2015-05-14 14:44 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.63 KB, patch)
2015-05-14 13:33 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-05-14 13:32:34 PDT
Local storage origins should include origins with transient local storage
Comment 1 Anders Carlsson 2015-05-14 13:33:58 PDT
Created attachment 253141 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-14 13:37:04 PDT
Attachment 253141 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:529:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2015-05-14 14:39:02 PDT
Comment on attachment 253141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253141&action=review

> Source/WebKit2/ChangeLog:5
> +        Local storage origins should include origins with transient local storage
> +        https://bugs.webkit.org/show_bug.cgi?id=145017
> +        rdar://problem/10690447

I think this needs a clearer explanation.  I assume this is transient local storage that is due to portioning, rather than private browsing mode.
Comment 4 Anders Carlsson 2015-05-14 14:44:56 PDT
Committed r184356: <http://trac.webkit.org/changeset/184356>