Bug 145012 – Add internals setting to disable wireless playback availability for layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Roger Fong]

<rdar://problem/20946504>

[Roger Fong]

Created attachment 253131 [details]
patch

[Roger Fong]

Doing this will allow local layout tests runs to be consistent with the bots.

[Roger Fong]

Created attachment 253132 [details]
patch

[Roger Fong]

Created attachment 253136 [details]
patch

[Eric Carlson]

Comment on attachment 253132 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253132&action=review

> Source/WebCore/testing/InternalSettings.cpp:366
> +    page->settings().setMediaPlaybackAllowsAirPlay(false);

I assume always setting it to false is a copy/paste bug?

> Source/WebCore/testing/InternalSettings.h:128
> +    void setWirelessPlaybackDisabled(bool);

This needs to be guarded with WIRELESS_PLAYBACK_TARGET.

[Eric Carlson]

Comment on attachment 253136 [details]
patch

r=me with the fixes mentioned

[Roger Fong]

Created attachment 253137 [details]
patch

patch with fixes to verify builds

[WebKit Commit Bot]

Attachment 253137 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Roger Fong]

Created attachment 253138 [details]
patch

[Roger Fong]

Created attachment 253139 [details]
patch

[WebKit Commit Bot]

Comment on attachment 253139 [details]
patch

Rejecting attachment 253139 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 253139, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5801458070978560

[Roger Fong]

http://trac.webkit.org/changeset/184351

[Alexey Proskuryakov]

Comment on attachment 253139 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253139&action=review

> Source/WebCore/testing/InternalSettings.h:128
> +    void setWirelessPlaybackDisabled(bool);

A more common idiom is to have a function like setWirelessPlaybackEnabled(bool), to avoid double negation, or to have a function without an argument. I think that the latter is more appropriate in this state.