Bug 144996 - [CSS Grid Layout] Switch from parenthesis to brackets for grid line names
Summary: [CSS Grid Layout] Switch from parenthesis to brackets for grid line names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-14 03:28 PDT by Sergio Villar Senin
Modified: 2015-06-04 07:11 PDT (History)
8 users (show)

See Also:

Attachments
Patch (130.32 KB, patch)
2015-06-02 07:43 PDT, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2015-05-14 03:28:16 PDT 
It was decided in the last F2F meeting https://lists.w3.org/Archives/Public/www-style/2015May/0175.html
Comment 1 Sergio Villar Senin 2015-06-02 07:43:33 PDT 
Created attachment 254069 [details]
Patch
Comment 2 Sergio Villar Senin 2015-06-02 23:45:18 PDT 
Committed r185147: <http://trac.webkit.org/changeset/185147>
Comment 3 Alexey Proskuryakov 2015-06-03 09:51:25 PDT 
This broke CSSPropertyParserTest.GridTrackLimits API test on Windows: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/52204/steps/run-api-tests/logs/stdio
Comment 4 Alexey Proskuryakov 2015-06-03 09:58:41 PDT 
Attempted a fix in <http://trac.webkit.org/r185154>.

Looks like CSS grid layout is enabled on Windows, but not on Mac. Is that intentional or accidental?
Comment 5 Simon Fraser (smfr) 2015-06-03 10:05:53 PDT 
ENABLE_CSS_GRID_LAYOUT is defined on trunk, but I seem to recall it being runtime-switchable?
Comment 6 Sergio Villar Senin 2015-06-04 07:11:37 PDT 
(In reply to comment #4)
> Attempted a fix in <http://trac.webkit.org/r185154>.

Thanks for the fix, I had totally forgotten about that test, even knowing that I had created it :)
 
> Looks like CSS grid layout is enabled on Windows, but not on Mac. Is that
> intentional or accidental?

IIRC it is enabled by default on developer builds for all ports.

(In reply to comment #5)
> ENABLE_CSS_GRID_LAYOUT is defined on trunk, but I seem to recall it being
> runtime-switchable?

Yeah it was runtime switchable but it was decided to move it to a build flag. Actually it was you Simon the one who reviewed my patch adding the ENABLE flag :), see https://bugs.webkit.org/show_bug.cgi?id=129153. Summarizing the issue is that we webexpose all the properties even if their correspondent features are runtime disabled, that's why it was decided to move it to a build flag.