Bug 144996 – [CSS Grid Layout] Switch from parenthesis to brackets for grid line names

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sergio Villar Senin]

It was decided in the last F2F meeting https://lists.w3.org/Archives/Public/www-style/2015May/0175.html

[Sergio Villar Senin]

Created attachment 254069 [details]
Patch

[Sergio Villar Senin]

Committed r185147: <http://trac.webkit.org/changeset/185147>

[Alexey Proskuryakov]

This broke CSSPropertyParserTest.GridTrackLimits API test on Windows: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/52204/steps/run-api-tests/logs/stdio

[Alexey Proskuryakov]

Attempted a fix in <http://trac.webkit.org/r185154>.

Looks like CSS grid layout is enabled on Windows, but not on Mac. Is that intentional or accidental?

[Simon Fraser (smfr)]

ENABLE_CSS_GRID_LAYOUT is defined on trunk, but I seem to recall it being runtime-switchable?

[Sergio Villar Senin]

(In reply to comment #4)
> Attempted a fix in <http://trac.webkit.org/r185154>.

Thanks for the fix, I had totally forgotten about that test, even knowing that I had created it :)
 
> Looks like CSS grid layout is enabled on Windows, but not on Mac. Is that
> intentional or accidental?

IIRC it is enabled by default on developer builds for all ports.

(In reply to comment #5)
> ENABLE_CSS_GRID_LAYOUT is defined on trunk, but I seem to recall it being
> runtime-switchable?

Yeah it was runtime switchable but it was decided to move it to a build flag. Actually it was you Simon the one who reviewed my patch adding the ENABLE flag :), see https://bugs.webkit.org/show_bug.cgi?id=129153. Summarizing the issue is that we webexpose all the properties even if their correspondent features are runtime disabled, that's why it was decided to move it to a build flag.