Bug 144988 – [GTK] ar warning when linking static libraries

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Linking CXX static library lib/libbmalloc.a
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')

It started to happen recently, probably because I upgraded binutils and this warning is new, and it happens for every static library we build. I have no idea what it means, bu in this redhat bug it's suggested to use either cr or crUu instead of cru as we currently use (and T also).

[Carlos Garcia Campos]

Forgot the link to the rh bz, https://bugzilla.redhat.com/show_bug.cgi?id=1155273

[Michael Catanzaro]

See also: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20082

[Michael Catanzaro]

Created attachment 256550 [details]
Patch

[Michael Catanzaro]

Created attachment 256551 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 256551 [details]
Patch

Ok, sounds reasonable. Thanks!

[Philippe Normand]

Comment on attachment 256551 [details]
Patch

Shouldn't we check the binutils version before removing the 'u'?

[Michael Catanzaro]

(In reply to comment #6)
> Comment on attachment 256551 [details]
> Patch
> 
> Shouldn't we check the binutils version before removing the 'u'?

I don't think so, since the issue is only slightly related to binutils version. What matters is whether the distro has decided to use deterministic builds by default or not. If we could find a way to check that, then we could use it determine whether or not to use u, but I don't think anybody else plans to do that, and there's not much point; I'd rather just remove 'u'. Also, since we use 'T' for thin archives, I doubt there's much any benefit to 'u' (but I haven't measured).

[WebKit Commit Bot]

Comment on attachment 256551 [details]
Patch

Clearing flags on attachment: 256551

Committed r186670: <http://trac.webkit.org/changeset/186670>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.