Bug 144972 - [SOUP] Assert when main resource handle is converted to download in network process
Summary: [SOUP] Assert when main resource handle is converted to download in network p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Major
Assignee: Nobody
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2015-05-13 14:34 PDT by Michael Catanzaro
Modified: 2015-05-15 01:45 PDT (History)
2 users (show)

See Also:


Attachments
backtrace of assertion (59.15 KB, text/plain)
2015-05-13 16:53 PDT, Michael Catanzaro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-05-13 14:34:54 PDT
After updating from 2.8.1 to 2.8.2, I can no longer download files.
Comment 1 Michael Catanzaro 2015-05-13 16:53:17 PDT
Created attachment 253074 [details]
backtrace of assertion

My debug build of 2.8.2 is hitting an assertion in the network process.

Note: If it matters, I tried to download the webkitgtk-2.8.2 tarball from webkitgtk.org.
Comment 3 Carlos Garcia Campos 2015-05-13 22:56:59 PDT
Interesting, this probably means I merged the commit that broke it in trunk :-)
Comment 4 Carlos Garcia Campos 2015-05-14 00:09:34 PDT
This is actually a duplicate of bug #144738, but the backtrace showed another problem. When converting a handle to a download, we assert in ResourceHandle::continueDidReceiveResponse(), because the download client doesn't use async callbacks.
Comment 5 Carlos Garcia Campos 2015-05-15 01:45:35 PDT
Fixed in r184376: <http://trac.webkit.org/changeset/184376>