RESOLVED FIXED144969
Work around HTMLMediaElement::documentDidResumeFromPageCache being called twice 
https://bugs.webkit.org/show_bug.cgi?id=144969
Summary Work around HTMLMediaElement::documentDidResumeFromPageCache being called twice
Eric Carlson
Reported 2015-05-13 13:49:27 PDT
HTMLMediaElement::documentDidResumeFromPageCache is called twice when a page is restored from the page cache, which causes Document::addPlaybackTargetPickerClient to assert in a debug build and to add the client twice in a release build.
Attachments
Proposed patch. (1.14 KB, text/plain)
2015-05-13 13:56 PDT, Eric Carlson 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-05-13 13:56:39 PDT
Created attachment 253057 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2015-05-13 13:57:34 PDT
<rdar://problem/20942403>
Alexey Proskuryakov
Comment 3 2015-05-13 13:58:28 PDT
Comment on attachment 253057 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=253057&action=review > Source/WebCore/dom/Document.cpp:6556 > - ASSERT(!m_clientToIDMap.contains(&client)); > + if (m_clientToIDMap.contains(&client)) > + return; Seems worth a FIXME with a bug number.
Eric Carlson
Comment 4 2015-05-13 14:16:35 PDT
(In reply to comment #3) > Comment on attachment 253057 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253057&action=review > > > Source/WebCore/dom/Document.cpp:6556 > > - ASSERT(!m_clientToIDMap.contains(&client)); > > + if (m_clientToIDMap.contains(&client)) > > + return; > > Seems worth a FIXME with a bug number. Indeed. I filed https://webkit.org/b/144970, will reference it in code.
Eric Carlson
Comment 5 2015-05-13 14:21:34 PDT
Committed r184306: https://trac.webkit.org/r184306
Note You need to log in before you can comment on or make changes to this bug.