Bug 144967 – [Content Extensions] Test interactions between multiple extensions and multiple domains.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

More tests help me sleep at night.

[Alex Christensen]

Created attachment 253054 [details]
Patch

[Benjamin Poulain]

Comment on attachment 253054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253054&action=review

> Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:499
> +    testRequest(backend, mainDocumentRequest("http://webkit.org"), { ContentExtensions::ActionType::CSSDisplayNoneStyleSheet });

I am confused by this result and the comment above. Why would you have an action ContentExtensions::ActionType::CSSDisplayNoneStyleSheet? You don't define any stylesheet in the rules above.

[Alex Christensen]

(In reply to comment #2)
> Comment on attachment 253054 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253054&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:499
> > +    testRequest(backend, mainDocumentRequest("http://webkit.org"), { ContentExtensions::ActionType::CSSDisplayNoneStyleSheet });
> 
> I am confused by this result and the comment above. Why would you have an
> action ContentExtensions::ActionType::CSSDisplayNoneStyleSheet? You don't
> define any stylesheet in the rules above.

There are two display-none stylesheet actions, one from each extension.  Each extension that does not hit an ignore-previous-rules appends a display-none stylesheet action to tell WebCore the name of the extension from which the display-none stylesheet came.  This is behaving correctly, but it could be cleaned up a bit later.

[WebKit Commit Bot]

Comment on attachment 253054 [details]
Patch

Clearing flags on attachment: 253054

Committed r184314: <http://trac.webkit.org/changeset/184314>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.