Bug 144967 - [Content Extensions] Test interactions between multiple extensions and multiple domains.
Summary: [Content Extensions] Test interactions between multiple extensions and multip...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-13 13:34 PDT by Alex Christensen
Modified: 2015-05-13 15:29 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.27 KB, patch)
2015-05-13 13:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-05-13 13:34:55 PDT 
More tests help me sleep at night.
Comment 1 Alex Christensen 2015-05-13 13:37:38 PDT 
Created attachment 253054 [details]
Patch
Comment 2 Benjamin Poulain 2015-05-13 14:31:54 PDT 
Comment on attachment 253054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253054&action=review

> Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:499
> +    testRequest(backend, mainDocumentRequest("http://webkit.org"), { ContentExtensions::ActionType::CSSDisplayNoneStyleSheet });

I am confused by this result and the comment above. Why would you have an action ContentExtensions::ActionType::CSSDisplayNoneStyleSheet? You don't define any stylesheet in the rules above.
Comment 3 Alex Christensen 2015-05-13 14:39:25 PDT 
(In reply to comment #2)
> Comment on attachment 253054 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253054&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:499
> > +    testRequest(backend, mainDocumentRequest("http://webkit.org"), { ContentExtensions::ActionType::CSSDisplayNoneStyleSheet });
> 
> I am confused by this result and the comment above. Why would you have an
> action ContentExtensions::ActionType::CSSDisplayNoneStyleSheet? You don't
> define any stylesheet in the rules above.

There are two display-none stylesheet actions, one from each extension.  Each extension that does not hit an ignore-previous-rules appends a display-none stylesheet action to tell WebCore the name of the extension from which the display-none stylesheet came.  This is behaving correctly, but it could be cleaned up a bit later.
Comment 4 WebKit Commit Bot 2015-05-13 15:29:05 PDT 
Comment on attachment 253054 [details]
Patch

Clearing flags on attachment: 253054

Committed r184314: <http://trac.webkit.org/changeset/184314>
Comment 5 WebKit Commit Bot 2015-05-13 15:29:08 PDT 
All reviewed patches have been landed.  Closing bug.