Bug 144957 – Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page. Reports of crashes after r183907.

> Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
> Exception Codes:       KERN_INVALID_ADDRESS at 0x00000000000000c8
> 
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0   WebKit::WebInspectorProxy::attachAvailabilityChanged(bool) + 58
> 1   WebKit::WebInspectorProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 748
> 2   IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) + 120
> 3   WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 24
> 4   IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 102
> 5   IPC::Connection::dispatchOneMessage() + 114
> 6   WTF::RunLoop::performWork() + 850
> 7   WTF::RunLoop::performWork(void*) + 34
> 8   __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
> 9   __CFRunLoopDoSources0 + 269
> 10  __CFRunLoopRun + 927

New code added here was:

> +    if (!m_underTest)
> +        m_inspectorPage->process().send(Messages::WebInspectorUI::SetDockingUnavailable(!m_canAttach), m_inspectorPage->pageID());

Seems that m_inspectorPage might not be set in these cases.

[Joseph Pecoraro]

<rdar://problem/20887443>

[Joseph Pecoraro]

Created attachment 253038 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 253038 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253038

Committed r184294: <http://trac.webkit.org/changeset/184294>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.