Bug 144957 - Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page
Summary: Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes op...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-13 11:14 PDT by Joseph Pecoraro
Modified: 2015-05-13 12:22 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.25 KB, patch)
2015-05-13 11:15 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-13 11:14:31 PDT 
* SUMMARY
Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page. Reports of crashes after r183907.

> Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
> Exception Codes:       KERN_INVALID_ADDRESS at 0x00000000000000c8
> 
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0   WebKit::WebInspectorProxy::attachAvailabilityChanged(bool) + 58
> 1   WebKit::WebInspectorProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 748
> 2   IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) + 120
> 3   WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 24
> 4   IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 102
> 5   IPC::Connection::dispatchOneMessage() + 114
> 6   WTF::RunLoop::performWork() + 850
> 7   WTF::RunLoop::performWork(void*) + 34
> 8   __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
> 9   __CFRunLoopDoSources0 + 269
> 10  __CFRunLoopRun + 927

New code added here was:

> +    if (!m_underTest)
> +        m_inspectorPage->process().send(Messages::WebInspectorUI::SetDockingUnavailable(!m_canAttach), m_inspectorPage->pageID());

Seems that m_inspectorPage might not be set in these cases.
Comment 1 Joseph Pecoraro 2015-05-13 11:14:48 PDT 
<rdar://problem/20887443>
Comment 2 Joseph Pecoraro 2015-05-13 11:15:48 PDT 
Created attachment 253038 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-05-13 12:22:10 PDT 
Comment on attachment 253038 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253038

Committed r184294: <http://trac.webkit.org/changeset/184294>
Comment 4 WebKit Commit Bot 2015-05-13 12:22:20 PDT 
All reviewed patches have been landed.  Closing bug.