WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144952
Cached CSS image resources don't show up after reloading <
http://nightly.webkit.org/start/
>
https://bugs.webkit.org/show_bug.cgi?id=144952
Summary
Cached CSS image resources don't show up after reloading <http://nightly.webk...
Antti Koivisto
Reported
2015-05-13 09:29:44 PDT
We don't revalidate resources on cached parsed stylesheets.
Attachments
patch
(39.83 KB, patch)
2015-05-13 09:46 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2015-05-13 09:43:08 PDT
rdar://problem/13387307
Antti Koivisto
Comment 2
2015-05-13 09:46:24 PDT
Created
attachment 253034
[details]
patch
WebKit Commit Bot
Comment 3
2015-05-13 09:48:49 PDT
Attachment 253034
[details]
did not pass style-queue: ERROR: Source/WebCore/css/CSSValueList.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/StyleSheetContents.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSCrossfadeValue.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSFilterImageValue.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSValue.h:126: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSValueList.cpp:154: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSValue.cpp:128: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSFontFaceSrcValue.cpp:94: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSCrossfadeValue.cpp:177: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSImageValue.h:53: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSFontFaceSrcValue.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSImageValue.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/StyleProperties.h:111: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/StyleProperties.cpp:1077: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSImageSetValue.cpp:187: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSFilterImageValue.cpp:152: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/CSSImageSetValue.h:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/StyleSheetContents.cpp:426: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/css/StyleSheetContents.cpp:466: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 19 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 4
2015-05-13 15:20:26 PDT
Comment on
attachment 253034
[details]
patch r=me
WebKit Commit Bot
Comment 5
2015-05-13 16:10:41 PDT
Comment on
attachment 253034
[details]
patch Clearing flags on attachment: 253034 Committed
r184315
: <
http://trac.webkit.org/changeset/184315
>
WebKit Commit Bot
Comment 6
2015-05-13 16:10:47 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug