Bug 144950 - Network Cache: Make Data::adoptMap take the ownership of the file descriptor
Summary: Network Cache: Make Data::adoptMap take the ownership of the file descriptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 144380
  Show dependency treegraph
 
Reported: 2015-05-13 02:01 PDT by Carlos Garcia Campos
Modified: 2015-05-17 23:31 PDT (History)
1 user (show)

See Also:


Attachments
Patch (15.67 KB, patch)
2015-05-13 02:10 PDT, Carlos Garcia Campos
koivisto: review+
Details | Formatted Diff | Diff
with xcode project file changes (30.70 KB, patch)
2015-05-15 06:33 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
with xcode project file changes (19.14 KB, patch)
2015-05-15 06:34 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
again with xcode project file changes (19.10 KB, patch)
2015-05-15 08:43 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-05-13 02:01:30 PDT
It will be required to implement ShareableResource for soup network backend. Also move the common code of Data to a common file and add mapToFile.
Comment 1 Carlos Garcia Campos 2015-05-13 02:10:37 PDT
Created attachment 253028 [details]
Patch

This will fail to build in mac, since I need someone with a mac who add the new file to xcode file.
Comment 2 Antti Koivisto 2015-05-15 06:33:00 PDT
Created attachment 253196 [details]
with xcode project file changes
Comment 3 Antti Koivisto 2015-05-15 06:34:15 PDT
Created attachment 253197 [details]
with xcode project file changes
Comment 4 Antti Koivisto 2015-05-15 08:43:20 PDT
Created attachment 253198 [details]
again with xcode project file changes
Comment 5 Carlos Garcia Campos 2015-05-17 23:31:40 PDT
Committed r184449: <http://trac.webkit.org/changeset/184449>