Bug 144936 - AX: [Win] REGRESSION(r184213) breaks aria-menubar-menuitems.html
Summary: AX: [Win] REGRESSION(r184213) breaks aria-menubar-menuitems.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-12 16:25 PDT by Joanmarie Diggs
Modified: 2015-05-12 20:43 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2015-05-12 16:44 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2015-05-12 19:47 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2015-05-12 16:25:21 PDT
As part of the fix for bug 144653, aria-menubar-menuitems.html was rewritten to be more cross-platform-friendly. Road to hell seems to be paved with good intentions.

My guess is that for some reason accessibleElementById is failing on the win port. I'll see about modifying the test to use focusedElement again.
Comment 1 Radar WebKit Bug Importer 2015-05-12 16:25:35 PDT
<rdar://problem/20927122>
Comment 2 Joanmarie Diggs 2015-05-12 16:44:02 PDT
Created attachment 252998 [details]
Patch
Comment 3 Joanmarie Diggs 2015-05-12 16:46:37 PDT
I'm *hoping* the attached will solve it. Note that the test will still fail because the expectations tree found here [1] looks very Mac-like and not Win-like. But if we get a tree rather than a TypeError, it will be progress. :)

[1]https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r184217%20(51780)/accessibility/aria-menubar-menuitems-pretty-diff.html
Comment 4 Joanmarie Diggs 2015-05-12 16:57:00 PDT
Chris: I'm playing "guess how I broke Win". This is just a change to the layout test, which works as expected for Gtk and Mac. Unless you have a better idea, r?
Comment 5 Joanmarie Diggs 2015-05-12 17:09:00 PDT
See also bug 140798 which makes me suspect my hunch is correct.
Comment 6 WebKit Commit Bot 2015-05-12 18:44:53 PDT
Comment on attachment 252998 [details]
Patch

Clearing flags on attachment: 252998

Committed r184227: <http://trac.webkit.org/changeset/184227>
Comment 7 WebKit Commit Bot 2015-05-12 18:44:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Joanmarie Diggs 2015-05-12 18:47:05 PDT
Reopening. I don't believe the changed test will automatically pass. But I need the test to run to get the tree needed for the win platform expectations. When I have that, I'll attach it here.
Comment 9 Joanmarie Diggs 2015-05-12 19:47:26 PDT
Created attachment 253010 [details]
Patch
Comment 10 Joanmarie Diggs 2015-05-12 19:49:30 PDT
Comment on attachment 253010 [details]
Patch

This is gardening. As a result of the change to the test, we're now getting an accessibility tree for Windows. The tree is consistent with the other ports and the original test results wrt Windows role mapping.
Comment 11 WebKit Commit Bot 2015-05-12 20:43:52 PDT
Comment on attachment 253010 [details]
Patch

Clearing flags on attachment: 253010

Committed r184239: <http://trac.webkit.org/changeset/184239>
Comment 12 WebKit Commit Bot 2015-05-12 20:43:55 PDT
All reviewed patches have been landed.  Closing bug.