Bug 144933 - com.apple.WebKit.WebContent crashed at JavaScriptCore: JSC::CodeBlock::finalizeUnconditionally
Summary: com.apple.WebKit.WebContent crashed at JavaScriptCore: JSC::CodeBlock::finali...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-12 15:54 PDT by Michael Saboff
Modified: 2015-05-13 11:00 PDT (History)
0 users

See Also:

Attachments
Patch (1.55 KB, patch)
2015-05-12 15:59 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Updated patch with release build fix and ChangeLog fix (1.56 KB, patch)
2015-05-12 21:07 PDT, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-05-12 15:54:48 PDT 
There are occasional crashes due to the RELEASE_ASSERT_NOT_REACHED in CodeBlock::finalizeUnconditionally.
It is probably better to change this to an ASSERT, as the RELEASE ASSERT is probably worse than what it is trying to protect.

rdar://problem/18717477
Comment 1 Michael Saboff 2015-05-12 15:59:40 PDT 
Created attachment 252995 [details]
Patch
Comment 2 Mark Lam 2015-05-12 17:56:42 PDT 
Comment on attachment 252995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252995&action=review

> Source/JavaScriptCore/ChangeLog:7
> +        determine the help determine the cause for any crash.

extra “determine the”.
Comment 3 Michael Saboff 2015-05-12 21:07:19 PDT 
Created attachment 253014 [details]
Updated patch with release build fix and ChangeLog fix
Comment 4 Geoffrey Garen 2015-05-13 10:24:01 PDT 
Comment on attachment 253014 [details]
Updated patch with release build fix and ChangeLog fix

r=me
Comment 5 Michael Saboff 2015-05-13 11:00:23 PDT 
Committed r184289: <http://trac.webkit.org/changeset/184289>