Bug 144931 - If JSC cannot get executable memory, it shouldn't call madvise
Summary: If JSC cannot get executable memory, it shouldn't call madvise
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-12 14:58 PDT by Michael Saboff
Modified: 2015-05-12 21:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2015-05-12 15:02 PDT, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-05-12 14:58:07 PDT 
If the mmap in OSAllocator::reserveAndCommit() fails, we shouldn't madvise(0, ...) in OSAllocator::reserveUncommitted().  This will likely adversely affect the application.

rdar://problem/19611967
rdar://problem/20733907
Comment 1 Michael Saboff 2015-05-12 15:02:57 PDT 
Created attachment 252988 [details]
Patch
Comment 2 Mark Lam 2015-05-12 17:55:23 PDT 
Comment on attachment 252988 [details]
Patch

r=me
Comment 3 Michael Saboff 2015-05-12 21:03:34 PDT 
Committed r184245: <http://trac.webkit.org/changeset/184245>