Bug 144929 - People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
Summary: People with Deuteranopia can't tell red and green apart on bot watcher's dash...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 14:24 PDT by Ryosuke Niwa
Modified: 2015-05-13 17:03 PDT (History)
4 users (show)

See Also:


Attachments
Tweaks bubble color (1.49 KB, patch)
2015-05-12 14:24 PDT, Ryosuke Niwa
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-05-12 14:24:16 PDT
People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
Comment 1 Ryosuke Niwa 2015-05-12 14:24:47 PDT
Created attachment 252983 [details]
Tweaks bubble color
Comment 2 Ryosuke Niwa 2015-05-12 14:31:44 PDT
Committed r184221: <http://trac.webkit.org/changeset/184221>
Comment 3 mitz 2015-05-12 14:36:58 PDT
Comment on attachment 252983 [details]
Tweaks bubble color

View in context: https://bugs.webkit.org/attachment.cgi?id=252983&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:84
> +    background-color: rgb(134, 189, 141);

Using the same color for good and bad is making things worse for some people. How is it helping anyone?
Comment 4 Ryosuke Niwa 2015-05-12 14:54:02 PDT
(In reply to comment #3)
> Comment on attachment 252983 [details]
> Tweaks bubble color
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252983&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:84
> > +    background-color: rgb(134, 189, 141);
> 
> Using the same color for good and bad is making things worse for some
> people. How is it helping anyone?

Fixed in http://trac.webkit.org/changeset/184222
Comment 5 Timothy Hatcher 2015-05-13 15:45:09 PDT
The new neon green is pretty horrid.
Comment 6 Ryosuke Niwa 2015-05-13 15:51:01 PDT
(In reply to comment #5)
> The new neon green is pretty horrid.

I'm all ears if you have other color to use. I'd actually prefer using blue since I don't think we use that for anything else.
Comment 7 Alexey Proskuryakov 2015-05-13 16:51:38 PDT
https://twitter.com/hashtag/greenbubbles
Comment 8 Ryosuke Niwa 2015-05-13 16:52:34 PDT
(In reply to comment #7)
> https://twitter.com/hashtag/greenbubbles

Why don't we use blue then. Blue is the good color, right?
Comment 10 Alexey Proskuryakov 2015-05-13 17:03:27 PDT
I'd be fine with whatever others decide. Adding a preference shouldn't be hard either.