Bug 144927 - Scroll snapping with padding in the container doesn't work
Summary: Scroll snapping with padding in the container doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-12 14:05 PDT by Brent Fulgham
Modified: 2016-12-21 12:28 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2016-12-21 10:53 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-05-12 14:05:57 PDT 
If you create a document with padding in the elements contained in the scroll-snap region, we get our calculations wrong and produce incorrect behavior.
Comment 1 Radar WebKit Bug Importer 2015-05-12 14:06:36 PDT 
<rdar://problem/20923772>
Comment 2 Wenson Hsieh 2016-12-21 10:53:16 PST 
Created attachment 297605 [details]
Patch
Comment 3 Brent Fulgham 2016-12-21 11:59:58 PST 
Comment on attachment 297605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297605&action=review

Looks good, and EWS is happy. r=me.

> LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt:1
> +Scroll-snap offsets are: vertical = { 0, 10, 625, 1240, 1660, 2275, 2890, 2920 }

I always get a little nervous about tests with specific pixel positions, since they can be flaky.
Comment 4 WebKit Commit Bot 2016-12-21 12:28:29 PST 
Comment on attachment 297605 [details]
Patch

Clearing flags on attachment: 297605

Committed r210072: <http://trac.webkit.org/changeset/210072>
Comment 5 WebKit Commit Bot 2016-12-21 12:28:33 PST 
All reviewed patches have been landed.  Closing bug.